Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29808584: Noissue - Use destructuring (Closed)

Created:
June 15, 2018, 8:09 p.m. by hub
Modified:
June 17, 2018, 11:02 p.m.
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Use destructuring

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/ioIndexedDB.js View 2 chunks +2 lines, -2 lines 3 comments Download

Messages

Total messages: 6
hub
June 15, 2018, 8:09 p.m. (2018-06-15 20:09:50 UTC) #1
hub
This one appeared after my previous patch with revision d97edcab2c18 (even though my patch landed ...
June 15, 2018, 8:10 p.m. (2018-06-15 20:10:51 UTC) #2
Sebastian Noack
LGTM https://codereview.adblockplus.org/29808584/diff/29808585/lib/ioIndexedDB.js File lib/ioIndexedDB.js (right): https://codereview.adblockplus.org/29808584/diff/29808585/lib/ioIndexedDB.js#newcode112 lib/ioIndexedDB.js:112: let {value} = cursor; Shouldn't this one at ...
June 15, 2018, 8:13 p.m. (2018-06-15 20:13:57 UTC) #3
hub
https://codereview.adblockplus.org/29808584/diff/29808585/lib/ioIndexedDB.js File lib/ioIndexedDB.js (right): https://codereview.adblockplus.org/29808584/diff/29808585/lib/ioIndexedDB.js#newcode112 lib/ioIndexedDB.js:112: let {value} = cursor; On 2018/06/15 20:13:57, Sebastian Noack ...
June 15, 2018, 8:20 p.m. (2018-06-15 20:20:03 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29808584/diff/29808585/lib/ioIndexedDB.js File lib/ioIndexedDB.js (right): https://codereview.adblockplus.org/29808584/diff/29808585/lib/ioIndexedDB.js#newcode112 lib/ioIndexedDB.js:112: let {value} = cursor; On 2018/06/15 20:20:03, hub wrote: ...
June 15, 2018, 9:18 p.m. (2018-06-15 21:18:33 UTC) #5
hub
June 17, 2018, 11:02 p.m. (2018-06-17 23:02:57 UTC) #6
Message was sent while issue was closed. 
On 2018/06/15 21:18:33, Sebastian Noack wrote:
> https://codereview.adblockplus.org/29808584/diff/29808585/lib/ioIndexedDB.js
> File lib/ioIndexedDB.js (right):
> 
>
https://codereview.adblockplus.org/29808584/diff/29808585/lib/ioIndexedDB.js#...
> lib/ioIndexedDB.js:112: let {value} = cursor;
> On 2018/06/15 20:20:03, hub wrote:
> > On 2018/06/15 20:13:57, Sebastian Noack wrote:
> > > Shouldn't this one at least trigger an eslint error?
> > 
> > both were triggered. that's why I'm fixing them.
> 
> Weird, not for me:
> 
> $ hg id
> d97edcab2c18 tip next
> $ hg st
> $ eslint *.js lib/ qunit/ ext/ chrome
> $

$ hg id
d97edcab2c18
$ `npm bin`/eslint *.js lib/ qunit/ ext/ chrome

/Users/hfiguiere/source/adblockpluschrome/lib/ioIndexedDB.js
  112:13  error  Use object destructuring  prefer-destructuring
  169:11  error  Use object destructuring  prefer-destructuring

/Users/hfiguiere/source/adblockpluschrome/lib/url.js
  37:9  error  Use object destructuring  prefer-destructuring

✖ 3 problems (3 errors, 0 warnings)
$ `npm bin`/eslint --version
v3.19.0
$

Powered by Google App Engine
This is Rietveld