Issue 29808596: Issue 6748 - Implement rewrite support in python-abp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29808596: Issue 6748 - Implement rewrite support in python-abp (Closed)

Created:
June 15, 2018, 10:50 p.m. by rhowell

Modified:
July 6, 2018, 5:09 p.m.

Reviewers:
Vasily Kuznetsov

Base URL:
https://hg.adblockplus.org/python-abp/

Visibility:
Public.

Description

Issue 6748 - Implement rewrite support in python-abp

Patch Set 1 #

Created: June 15, 2018, 10:50 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	abp/filters/parser.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	tests/test_parser.py	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rhowell

On 2018/06/15 22:50:07, rhowell wrote: Hey Vasily, I only saw one test in abpcore for ...

June 15, 2018, 10:55 p.m. (2018-06-15 22:55:11 UTC) #2

Vasily Kuznetsov

June 18, 2018, 3:59 p.m. (2018-06-18 15:59:40 UTC) #3

On 2018/06/15 22:55:11, rhowell wrote:
> On 2018/06/15 22:50:07, rhowell wrote:
> 
> Hey Vasily,
> 
> I only saw one test in abpcore for parsing this option
> (https://hg.adblockplus.org/adblockpluscore/rev/e59042524857#l4.48), so I
> implemented a similar test.
> 
> The other tests there ^ seem to check that the URL is being rewritten
properly,
> but (if I understand correctly), we aren't implementing that part, right? We
> just need to parse the option?

Yes, this is right.

> 
> Best,
> Rosie

LGTM

Expand All Messages | Collapse All Messages