Issue #6526 - pass v8::Isolate to more functions because old approach is deprecated

src/ConsoleJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 25 matching lines @@
     std::stringstream message;
     for (size_t i = 0; i < converted.size(); i++)
     {
       if (i > 0)
         message << " ";
       message << converted[i].AsString();
     }
 
     std::stringstream source;
     v8::Local<v8::StackFrame> frame = v8::StackTrace::CurrentStackTrace(arguments.GetIsolate(), 1)->GetFrame(0);
-    source << AdblockPlus::Utils::FromV8String(frame->GetScriptName());
+    source << AdblockPlus::Utils::FromV8String(arguments.GetIsolate(), frame->GetScriptName());
     source << ":" << frame->GetLineNumber();
 
     jsEngine->GetPlatform().WithLogSystem(
       [logLevel, &message, &source](AdblockPlus::LogSystem& callback)
       {
         callback(logLevel, message.str(), source.str());
       });
   }
 
   void LogCallback(const v8::FunctionCallbackInfo<v8::Value>& arguments)
@@ skipping 26 matching lines @@
     AdblockPlus::JsEnginePtr jsEngine = AdblockPlus::JsEngine::FromArguments(arguments);
     const AdblockPlus::JsContext context(*jsEngine);
     AdblockPlus::JsValueList converted = jsEngine->ConvertArguments(arguments);
 
     std::stringstream traceback;
     v8::Local<v8::StackTrace> frames = v8::StackTrace::CurrentStackTrace(arguments.GetIsolate(), 100);
     for (int i = 0, l = frames->GetFrameCount(); i < l; i++)
     {
       v8::Local<v8::StackFrame> frame = frames->GetFrame(i);
       traceback << (i + 1) << ": ";
-      std::string name = AdblockPlus::Utils::FromV8String(frame->GetFunctionName());
+      std::string name = AdblockPlus::Utils::FromV8String(arguments.GetIsolate(), frame->GetFunctionName());
       if (name.size())
         traceback << name;
       else
         traceback << "/* anonymous */";
       traceback << "() at ";
-      traceback << AdblockPlus::Utils::FromV8String(frame->GetScriptName());
+      traceback << AdblockPlus::Utils::FromV8String(arguments.GetIsolate(), frame->GetScriptName());
       traceback << ":" << frame->GetLineNumber();
       traceback << std::endl;
     }
 
     jsEngine->GetPlatform().WithLogSystem(
       [&traceback](AdblockPlus::LogSystem& callback)
       {
         callback(AdblockPlus::LogSystem::LOG_LEVEL_TRACE, traceback.str(), "");
       });
   }
 }
 
 AdblockPlus::JsValue& AdblockPlus::ConsoleJsObject::Setup(
     AdblockPlus::JsEngine& jsEngine, AdblockPlus::JsValue& obj)
 {
   obj.SetProperty("log", jsEngine.NewCallback(::LogCallback));
   obj.SetProperty("debug", jsEngine.NewCallback(::DebugCallback));
   obj.SetProperty("info", jsEngine.NewCallback(::InfoCallback));
   obj.SetProperty("warn", jsEngine.NewCallback(::WarnCallback));
   obj.SetProperty("error", jsEngine.NewCallback(::ErrorCallback));
   obj.SetProperty("trace", jsEngine.NewCallback(::TraceCallback));
   return obj;
 }