Issue #6526 - pass v8::Isolate to more functions because old approach is deprecated

Beside v8::Isolate some places now start to pass current context, though the implementation is not complete yet because there is no check of the return value.

Despite it can seem that static JsError::ExceptionToString should return an optinal/maybe value if there is no value, IMO it would be better to get as much as possible information, even just a string "unknown line" when it is about an exception. Perhaps even such information can already help to find out the bug, notice it or debug it.

[sergei, 2018-06-18 10:34:06]

Since it has some changes what can be a source of bugs I'm not sure that it
should be delivered to our partners ASAP. I would propose to review it now but
land after their freezing of the version in their current iteration.

[hub, 2018-06-18 12:59:02]

https://codereview.adblockplus.org/29809555/diff/29809556/src/FileSystemJsObj...
File src/FileSystemJsObject.cpp (right):

https://codereview.adblockplus.org/29809555/diff/29809556/src/FileSystemJsObj...
src/FileSystemJsObject.cpp:191: processFunc->Call(v8Context, globalContext, 1,
&jsLine);
I get this warning here:

../src/FileSystemJsObject.cpp:191:17: warning: ignoring return value of function
declared with 'warn_unused_result' attribute [-Wunused-result]
                processFunc->Call(v8Context, globalContext, 1, &jsLine);
                ^~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

[sergei, 2018-06-18 13:00:19]

https://codereview.adblockplus.org/29809555/diff/29809556/src/FileSystemJsObj...
File src/FileSystemJsObject.cpp (right):

https://codereview.adblockplus.org/29809555/diff/29809556/src/FileSystemJsObj...
src/FileSystemJsObject.cpp:191: processFunc->Call(v8Context, globalContext, 1,
&jsLine);
On 2018/06/18 12:59:02, hub wrote:
> I get this warning here:
> 
> ../src/FileSystemJsObject.cpp:191:17: warning: ignoring return value of
function
> declared with 'warn_unused_result' attribute [-Wunused-result]
>                 processFunc->Call(v8Context, globalContext, 1, &jsLine);
>                 ^~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 warning generated.

Yeah, that's because the impl is not complete yet.

[hub, 2018-06-18 13:01:04]

if you are good with it, LGTM.

[sergei, 2018-06-18 13:19:55]

On 2018/06/18 13:01:04, hub wrote:
> if you are good with it, LGTM.

yes, I'm good with it, the return value is not checked and it will be addressed
in the next codereviews.