Issue #6526 - pass v8::Isolate to more functions because old approach is deprecated

src/JsValue.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 106 matching lines @@
 
 bool AdblockPlus::JsValue::IsFunction() const
 {
   const JsContext context(*jsEngine);
   return UnwrapValue()->IsFunction();
 }
 
 std::string AdblockPlus::JsValue::AsString() const
 {
   const JsContext context(*jsEngine);
-  return Utils::FromV8String(UnwrapValue());
+  return Utils::FromV8String(jsEngine->GetIsolate(), UnwrapValue());
 }
 
 StringBuffer AdblockPlus::JsValue::AsStringBuffer() const
 {
   const JsContext context(*jsEngine);
-  return Utils::StringBufferFromV8String(UnwrapValue());
+  return Utils::StringBufferFromV8String(jsEngine->GetIsolate(), UnwrapValue());
 }
 
 int64_t AdblockPlus::JsValue::AsInt() const
 {
   const JsContext context(*jsEngine);
   return UnwrapValue()->IntegerValue();
 }
 
 bool AdblockPlus::JsValue::AsBool() const
 {
@@ skipping 89 matching lines @@
   SetProperty(name, v8::Boolean::New(jsEngine->GetIsolate(), val));
 }
 
 std::string AdblockPlus::JsValue::GetClass() const
 {
   if (!IsObject())
     throw std::runtime_error("Cannot get constructor of a non-object");
 
   const JsContext context(*jsEngine);
   v8::Local<v8::Object> obj = v8::Local<v8::Object>::Cast(UnwrapValue());
-  return Utils::FromV8String(obj->GetConstructorName());
+  return Utils::FromV8String(jsEngine->GetIsolate(), obj->GetConstructorName());
 }
 
 JsValue JsValue::Call(const JsValueList& params) const
 {
   const JsContext context(*jsEngine);
   std::vector<v8::Local<v8::Value>> argv;
   for (const auto& param : params)
     argv.push_back(param.UnwrapValue());
 
   return Call(argv, context.GetV8Context()->Global());
@@ skipping 27 matching lines @@
     throw std::runtime_error("Attempting to call a non-function");
   if (!thisObj->IsObject())
     throw std::runtime_error("`this` pointer has to be an object");
 
   const JsContext context(*jsEngine);
 
   const v8::TryCatch tryCatch(jsEngine->GetIsolate());
   v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(UnwrapValue());
   v8::Local<v8::Value> result = func->Call(thisObj, args.size(),
     args.size() ? &args[0] : nullptr);
-
   if (tryCatch.HasCaught())
-    throw JsError(tryCatch.Exception(), tryCatch.Message());
+    throw JsError(jsEngine->GetIsolate(), tryCatch.Exception(), tryCatch.Message());
 
   return JsValue(jsEngine, result);
 }