Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/ConsoleJsObject.cpp

Issue 29809555: Issue #6526 - pass v8::Isolate to more functions because old approach is deprecated (Closed) Base URL: https://github.com/adblockplus/libadblockplus@4d9bcc12e77369cbc4bc04bace9a3e7fa03de17b
Patch Set: Created June 18, 2018, 10:22 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/FileSystemJsObject.cpp » ('j') | src/FileSystemJsObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ConsoleJsObject.cpp
diff --git a/src/ConsoleJsObject.cpp b/src/ConsoleJsObject.cpp
index d4e8efacee0865864afc3b48ae6dfc09028ce0b9..0f0f4979125d6698005bd1c3edbeab212d143877 100644
--- a/src/ConsoleJsObject.cpp
+++ b/src/ConsoleJsObject.cpp
@@ -43,7 +43,7 @@ namespace
std::stringstream source;
v8::Local<v8::StackFrame> frame = v8::StackTrace::CurrentStackTrace(arguments.GetIsolate(), 1)->GetFrame(0);
- source << AdblockPlus::Utils::FromV8String(frame->GetScriptName());
+ source << AdblockPlus::Utils::FromV8String(arguments.GetIsolate(), frame->GetScriptName());
source << ":" << frame->GetLineNumber();
jsEngine->GetPlatform().WithLogSystem(
@@ -90,13 +90,13 @@ namespace
{
v8::Local<v8::StackFrame> frame = frames->GetFrame(i);
traceback << (i + 1) << ": ";
- std::string name = AdblockPlus::Utils::FromV8String(frame->GetFunctionName());
+ std::string name = AdblockPlus::Utils::FromV8String(arguments.GetIsolate(), frame->GetFunctionName());
if (name.size())
traceback << name;
else
traceback << "/* anonymous */";
traceback << "() at ";
- traceback << AdblockPlus::Utils::FromV8String(frame->GetScriptName());
+ traceback << AdblockPlus::Utils::FromV8String(arguments.GetIsolate(), frame->GetScriptName());
traceback << ":" << frame->GetLineNumber();
traceback << std::endl;
}
« no previous file with comments | « no previous file | src/FileSystemJsObject.cpp » ('j') | src/FileSystemJsObject.cpp » ('J')

Powered by Google App Engine
This is Rietveld