Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/Utils.h

Issue 29809555: Issue #6526 - pass v8::Isolate to more functions because old approach is deprecated (Closed) Base URL: https://github.com/adblockplus/libadblockplus@4d9bcc12e77369cbc4bc04bace9a3e7fa03de17b
Patch Set: Created June 18, 2018, 10:22 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/Utils.h
diff --git a/src/Utils.h b/src/Utils.h
index f68780e33ca745a6b9d00724738b619aec44ab68..93ca83d15a71afd6afbbd9a09c2f0abf16372c3f 100644
--- a/src/Utils.h
+++ b/src/Utils.h
@@ -31,8 +31,8 @@ namespace AdblockPlus
{
namespace Utils
{
- std::string FromV8String(const v8::Local<v8::Value>& value);
- StringBuffer StringBufferFromV8String(const v8::Local<v8::Value>& value);
+ std::string FromV8String(v8::Isolate* isolate, const v8::Local<v8::Value>& value);
+ StringBuffer StringBufferFromV8String(v8::Isolate* isolate, const v8::Local<v8::Value>& value);
v8::Local<v8::String> ToV8String(v8::Isolate* isolate, const std::string& str);
v8::Local<v8::String> StringBufferToV8String(v8::Isolate* isolate, const StringBuffer& bytes);
void ThrowExceptionInJS(v8::Isolate* isolate, const std::string& str);
« src/FileSystemJsObject.cpp ('K') | « src/JsValue.cpp ('k') | src/Utils.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld