Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29809575: Fixes #91 - Updates to polish page from review 29800606 (Closed)

Created:
June 18, 2018, 1:59 p.m. by juliandoucette
Modified:
June 20, 2018, 6:06 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Fixes #91 - Updates to polish page from review 29800606

Patch Set 1 : Last Patchset from 29800606 #

Patch Set 2 : Changes made before publishing #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3355 lines, -0 lines) Patch
A static/poland.html View 1 1 chunk +300 lines, -0 lines 1 comment Download
A static/poland/css/defaults.css View 1 chunk +539 lines, -0 lines 0 comments Download
A static/poland/css/fonts.css View 1 1 chunk +255 lines, -0 lines 0 comments Download
A static/poland/css/index.css View 1 chunk +361 lines, -0 lines 0 comments Download
A static/poland/css/main.css View 1 chunk +877 lines, -0 lines 0 comments Download
A static/poland/fonts/Source-Sans-Pro/300/cyrillic.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/300/cyrillic-ext.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/300/greek.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/300/greek-ext.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/300/latin.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/300/latin-ext.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/300/vietnamese.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/400/cyrillic.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/400/cyrillic-ext.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/400/greek.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/400/greek-ext.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/400/latin.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/400/latin-ext.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/400/vietnamese.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/700/cyrillic.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/700/cyrillic-ext.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/700/greek.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/700/greek-ext.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/700/latin.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/700/latin-ext.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/700/vietnamese.woff2 View 1 Binary file 0 comments Download
A static/poland/fonts/Source-Sans-Pro/LICENSE.txt View 1 1 chunk +93 lines, -0 lines 0 comments Download
A static/poland/img/abb-logo.png View Binary file 0 comments Download
A static/poland/img/apple-app-store-badge.png View Binary file 0 comments Download
A static/poland/img/apple-app-store-badge.svg View 1 chunk +41 lines, -0 lines 0 comments Download
A static/poland/img/external-icon.png View Binary file 0 comments Download
A static/poland/img/external-icon.svg View 1 chunk +13 lines, -0 lines 0 comments Download
A static/poland/img/feature-aa.png View Binary file 0 comments Download
A static/poland/img/feature-aa.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/poland/img/feature-fast.png View Binary file 0 comments Download
A static/poland/img/feature-fast.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/poland/img/feature-safe.png View Binary file 0 comments Download
A static/poland/img/feature-safe.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/poland/img/footer-facebook-glyphicon.png View Binary file 0 comments Download
A static/poland/img/footer-instagram-glyphicon.png View Binary file 0 comments Download
A static/poland/img/footer-twitter-glyphicon.png View Binary file 0 comments Download
A static/poland/img/footer-youtube-glyphicon.png View Binary file 0 comments Download
A static/poland/img/google-play-badge.png View Binary file 0 comments Download
A static/poland/img/hero-video.jpg View Binary file 0 comments Download
A static/poland/img/hero-video-2x.jpg View Binary file 0 comments Download
A static/poland/img/media/business-insider.png View Binary file 0 comments Download
A static/poland/img/media/business-insider-2x.png View Binary file 0 comments Download
A static/poland/img/media/mediapost.png View Binary file 0 comments Download
A static/poland/img/media/mediapost-2x.png View Binary file 0 comments Download
A static/poland/img/media/nyt.png View Binary file 0 comments Download
A static/poland/img/media/nyt-2x.png View Binary file 0 comments Download
A static/poland/img/media/techcrunch.png View Binary file 0 comments Download
A static/poland/img/media/techcrunch-2x.png View Binary file 0 comments Download
A static/poland/img/media/wsj.png View Binary file 0 comments Download
A static/poland/img/media/wsj-2x.png View Binary file 0 comments Download
A static/poland/img/menu-toggle.png View Binary file 0 comments Download
A static/poland/img/menu-toggle.svg View 1 chunk +43 lines, -0 lines 0 comments Download
A static/poland/img/navbar-logo.png View Binary file 0 comments Download
A static/poland/img/navbar-logo.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/poland/img/video-play.png View Binary file 0 comments Download
A static/poland/js/bowser.js View 1 chunk +601 lines, -0 lines 0 comments Download
A static/poland/js/index.js View 1 1 chunk +57 lines, -0 lines 0 comments Download
A static/poland/js/main.js View 1 chunk +171 lines, -0 lines 0 comments Download

Messages

Total messages: 9
juliandoucette
June 18, 2018, 2 p.m. (2018-06-18 14:00:20 UTC) #1
juliandoucette
Updated installer links
June 18, 2018, 2:19 p.m. (2018-06-18 14:19:16 UTC) #2
ire
Thanks Julian, just one comment https://codereview.adblockplus.org/29809575/diff/29809682/static/poland.html File static/poland.html (right): https://codereview.adblockplus.org/29809575/diff/29809682/static/poland.html#newcode40 static/poland.html:40: <a id="navbar-menu-toggle"> No `href` ...
June 18, 2018, 11:38 p.m. (2018-06-18 23:38:12 UTC) #3
juliandoucette
On 2018/06/18 23:38:12, ire wrote: > No `href` attribute? Clicking a.href=# causes the page to ...
June 19, 2018, 10:45 a.m. (2018-06-19 10:45:13 UTC) #4
juliandoucette
On 2018/06/19 10:45:13, juliandoucette wrote: > Clicking a.href=# causes the page to scroll to top. ...
June 19, 2018, 10:46 a.m. (2018-06-19 10:46:36 UTC) #5
ire
On 2018/06/19 10:46:36, juliandoucette wrote: > On 2018/06/19 10:45:13, juliandoucette wrote: > > Clicking a.href=# ...
June 19, 2018, 3:02 p.m. (2018-06-19 15:02:45 UTC) #6
juliandoucette
On 2018/06/19 15:02:45, ire wrote: > Then we should make it a button instead of ...
June 19, 2018, 5:28 p.m. (2018-06-19 17:28:26 UTC) #7
juliandoucette
On 2018/06/19 15:02:45, ire wrote: > Then we should make it a button instead of ...
June 19, 2018, 5:34 p.m. (2018-06-19 17:34:12 UTC) #8
ire
June 20, 2018, 6:06 p.m. (2018-06-20 18:06:58 UTC) #9
Message was sent while issue was closed.
On 2018/06/19 17:34:12, juliandoucette wrote:
> On 2018/06/19 15:02:45, ire wrote:
> > Then we should make it a button instead of a link. If it's only purpose is
to
> > toggle the navbar, then a button makes more sense semantically.
> 
> (I will address this separately at low priority.)
> 
> Also, FYI: https://hg.adblockplus.org/web.adblockplus.org/rev/9f272e7a6766
> 
> And: http://hub.eyeo.com/issues/12411
> 
> These changes were/are necessary because the comms team needed to start right
> away (apparently :/).
> 
> I tested them myself before publishing. And I will get additional help testing
> today/tomorrow.

Ack

Powered by Google App Engine
This is Rietveld