Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29810565: Issue 6750 - Update libadblockplus dependency to revision hg:70579fb48a6c (Closed)

Created:
June 19, 2018, 2:16 p.m. by anton
Modified:
June 21, 2018, 6:21 p.m.
CC:
René Jeschke, hub
Visibility:
Public.

Description

Issue 6750 - Update libadblockplus dependency to revision hg:70579fb48a6c

Patch Set 1 #

Patch Set 2 : Supporting multiple shared V8 libraries. #

Patch Set 3 : Renamed variable #

Patch Set 4 : Renamed another variable (to be consistent) #

Patch Set 5 : Updated revisions, README #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -89 lines) Patch
M README.md View 1 2 3 4 3 chunks +19 lines, -7 lines 0 comments Download
M dependencies View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus-android/jni/Android.mk View 1 2 3 2 chunks +70 lines, -81 lines 0 comments Download

Messages

Total messages: 6
anton
Tested to work with prebuilt static V8 libraries only - shared v8 not tested (though ...
June 19, 2018, 2:17 p.m. (2018-06-19 14:17:42 UTC) #1
sergei
AFAIR when one calls `gradlew assemble` it builds binaries for several architectures, but it seems ...
June 19, 2018, 2:34 p.m. (2018-06-19 14:34:55 UTC) #2
anton
On 2018/06/19 14:34:55, sergei wrote: > AFAIR when one calls `gradlew assemble` it builds binaries ...
June 19, 2018, 8:35 p.m. (2018-06-19 20:35:38 UTC) #3
diegocarloslima
On 2018/06/19 20:35:38, anton wrote: > On 2018/06/19 14:34:55, sergei wrote: > > AFAIR when ...
June 20, 2018, 4:27 p.m. (2018-06-20 16:27:34 UTC) #4
anton
On 2018/06/20 16:27:34, diegocarloslima wrote: > On 2018/06/19 20:35:38, anton wrote: > > On 2018/06/19 ...
June 21, 2018, 6:13 a.m. (2018-06-21 06:13:46 UTC) #5
jens
June 21, 2018, 6:22 a.m. (2018-06-21 06:22:12 UTC) #6 
On 2018/06/21 06:13:46, anton wrote:
> On 2018/06/20 16:27:34, diegocarloslima wrote:
> > On 2018/06/19 20:35:38, anton wrote:
> > > On 2018/06/19 14:34:55, sergei wrote:
> > > > AFAIR when one calls `gradlew assemble` it builds binaries for several
> > > > architectures, but it seems not covered here. Could you please clarify
it.
> > > 
> > > That's correct - it builds "..Abi_all" build flavour so both `x86` and
`arm`
> > > prebuilt binaries are required.
> > > This will not work at the moment since prebuilt binaries are downloaded
for
> > one
> > > ARCH and should be done manually.
> > 
> > LGTM
> 
> Also i was able to link dynamically with v8 (6.7 from chromium 67) and
> libadblockplus statically:
> 
> ---
> ~/Documents/dev/src/libadblockplus-android.ssh
> asmirnov$SHARED_V8_LIB_FILENAMES="libv8.cr.so libv8_libbase.cr.so
> libv8_libplatform.cr.so" SHARED_V8_LIB_DIR=/tmp/shared_v8/67/release ./gradlew
> assembleAbi_arm
> [Configuration] Using libadblockplus-android ABI flavor: abi_arm
> [Configuration] Excluding shared v8 library libv8.cr.so from AAR
> [Configuration] Excluding shared v8 library libv8_libbase.cr.so from AAR
> [Configuration] Excluding shared v8 library libv8_libplatform.cr.so from AAR
> Incremental java compilation is an incubating feature.
> :libadblockplus-android:preBuild UP-TO-DATE
> :libadblockplus-android:preAbi_armDebugBuild UP-TO-DATE
> :libadblockplus-android:checkAbi_armDebugManifest
> :libadblockplus-android:prepareAbi_armDebugDependencies
> :libadblockplus-android:compileAbi_armDebugAidl
> :libadblockplus-android:compileLint
> :libadblockplus-android:copyAbi_armDebugLint UP-TO-DATE
> :libadblockplus-android:mergeAbi_armDebugShaders
> :libadblockplus-android:compileAbi_armDebugShaders
> :libadblockplus-android:generateAbi_armDebugAssets
> :libadblockplus-android:mergeAbi_armDebugAssets
> :libadblockplus-android:mergeAbi_armDebugProguardFiles UP-TO-DATE
> :libadblockplus-android:packageAbi_armDebugRenderscript UP-TO-DATE
> :libadblockplus-android:compileAbi_armDebugRenderscript
> :libadblockplus-android:generateAbi_armDebugResValues
> :libadblockplus-android:generateAbi_armDebugResources
> :libadblockplus-android:packageAbi_armDebugResources
> :libadblockplus-android:processAbi_armDebugManifest
> :libadblockplus-android:generateAbi_armDebugBuildConfig
> :libadblockplus-android:processAbi_armDebugResources
> :libadblockplus-android:generateAbi_armDebugSources
> :libadblockplus-android:incrementalAbi_armDebugJavaCompilationSafeguard
> :libadblockplus-android:javaPreCompileAbi_armDebug
> :libadblockplus-android:compileAbi_armDebugJavaWithJavac
> :libadblockplus-android:compileAbi_armDebugJavaWithJavac - is not incremental
> (e.g. outputs have changed, no previous execution, etc.).
> :libadblockplus-android:processAbi_armDebugJavaRes UP-TO-DATE
> :libadblockplus-android:transformResourcesWithMergeJavaResForAbi_armDebug
>
:libadblockplus-android:transformClassesAndResourcesWithSyncLibJarsForAbi_armDebug
> :libadblockplus-android:generateJsonModelAbi_armDebug
> :libadblockplus-android:externalNativeBuildAbi_armDebug
> Build adblockplus-jni armeabi-v7a
> [Configuration] Pass LIBABP_INCLUDE_DIR to set libadblockplus headers
directory,
> using default value.
> [Configuration] Using libadblockplus headers directory
>
/Users/asmirnov/Documents/dev/src/libadblockplus-android.ssh/libadblockplus-android/../libadblockplus/include
> [Configuration] Pass LIBABP_LIB_DIR to set static libadblockplus library
> directory, using default value.
> [Configuration] Using static libadblockplus library
>
/Users/asmirnov/Documents/dev/src/libadblockplus-android.ssh/libadblockplus-android/../libadblockplus/build/local/armeabi-v7a/libadblockplus.a
> [Configuration] Pass V8_INCLUDE_DIR to set V8 headers directory, using default
> value.
> [Configuration] Using V8 headers directory
>
/Users/asmirnov/Documents/dev/src/libadblockplus-android.ssh/libadblockplus-android/../libadblockplus/third_party/prebuilt-v8/include
> [Configuration] Linking dynamically with shared v8 library
> /tmp/shared_v8/67/release/libv8.cr.so
> [Configuration] Linking dynamically with shared v8 library
> /tmp/shared_v8/67/release/libv8_libbase.cr.so
> [Configuration] Linking dynamically with shared v8 library
> /tmp/shared_v8/67/release/libv8_libplatform.cr.so
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniLibrary.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniPlatform.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniJsEngine.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniFilterEngine.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniJsValue.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniFilter.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniSubscription.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniEventCallback.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniLogSystem.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniWebRequest.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <=
JniUpdateAvailableCallback.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <=
JniUpdateCheckDoneCallback.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniFilterChangeCallback.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniCallbacks.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= Utils.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <= JniNotification.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <=
> JniShowNotificationCallback.cpp
> [armeabi-v7a] Compile++ thumb: adblockplus-jni <=
> JniIsAllowedConnectionTypeCallback.cpp
> [armeabi-v7a] Prebuilt       : libv8.cr.so <= /tmp/shared_v8/67/release/
> [armeabi-v7a] Prebuilt       : libv8_libbase.cr.so <=
/tmp/shared_v8/67/release/
> [armeabi-v7a] Prebuilt       : libv8_libplatform.cr.so <=
> /tmp/shared_v8/67/release/
> [armeabi-v7a] SharedLibrary  : libadblockplus-jni.so
> :libadblockplus-android:mergeAbi_armDebugJniLibFolders
> :libadblockplus-android:transformNativeLibsWithMergeJniLibsForAbi_armDebug
> :libadblockplus-android:transformNativeLibsWithStripDebugSymbolForAbi_armDebug
> :libadblockplus-android:transformNativeLibsWithSyncJniLibsForAbi_armDebug
> :libadblockplus-android:bundleAbi_armDebug
> :libadblockplus-android:compileAbi_armDebugSources
> :libadblockplus-android:assembleAbi_armDebug
> ---

LGTM

Powered by Google App Engine
This is Rietveld