Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/Utils.cpp

Issue 29810573: Issue 6526 - Remove deprecated Utf8Value() usage (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created June 19, 2018, 5:11 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/Utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/Utils.cpp
===================================================================
--- a/src/Utils.cpp
+++ b/src/Utils.cpp
@@ -21,28 +21,28 @@
#include <Windows.h>
#include <Shlwapi.h>
#endif
#include "Utils.h"
using namespace AdblockPlus;
-std::string Utils::FromV8String(const v8::Local<v8::Value>& value)
+std::string Utils::FromV8String(v8::Isolate* isolate, const v8::Local<v8::Value>& value)
{
- v8::String::Utf8Value stringValue(value);
+ v8::String::Utf8Value stringValue(isolate, value);
if (stringValue.length())
return std::string(*stringValue, stringValue.length());
else
return std::string();
}
-StringBuffer Utils::StringBufferFromV8String(const v8::Local<v8::Value>& value)
+StringBuffer Utils::StringBufferFromV8String(v8::Isolate* isolate, const v8::Local<v8::Value>& value)
{
- v8::String::Utf8Value stringValue(value);
+ v8::String::Utf8Value stringValue(isolate, value);
if (stringValue.length())
return IFileSystem::IOBuffer(*stringValue, *stringValue + stringValue.length());
else
return IFileSystem::IOBuffer();
}
v8::Local<v8::String> Utils::ToV8String(v8::Isolate* isolate, const std::string& str)
{
« no previous file with comments | « src/Utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld