Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/Utils.h

Issue 29810573: Issue 6526 - Remove deprecated Utf8Value() usage (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created June 19, 2018, 5:11 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/JsValue.cpp ('k') | src/Utils.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/Utils.h
===================================================================
--- a/src/Utils.h
+++ b/src/Utils.h
@@ -26,18 +26,18 @@
#include <v8.h>
#include "AdblockPlus/JsValue.h"
namespace AdblockPlus
{
namespace Utils
{
- std::string FromV8String(const v8::Local<v8::Value>& value);
- StringBuffer StringBufferFromV8String(const v8::Local<v8::Value>& value);
+ std::string FromV8String(v8::Isolate* isolate, const v8::Local<v8::Value>& value);
+ StringBuffer StringBufferFromV8String(v8::Isolate* isolate, const v8::Local<v8::Value>& value);
v8::Local<v8::String> ToV8String(v8::Isolate* isolate, const std::string& str);
v8::Local<v8::String> StringBufferToV8String(v8::Isolate* isolate, const StringBuffer& bytes);
void ThrowExceptionInJS(v8::Isolate* isolate, const std::string& str);
// Code for templated function has to be in a header file, can't be in .cpp
template<class T>
T TrimString(const T& text)
{
« no previous file with comments | « src/JsValue.cpp ('k') | src/Utils.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld