src/JsError.cpp - Issue 29810583: Issue 6526 - Use new v8::Message::GetLineNumber() API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/JsError.cpp

Issue 29810583: Issue 6526 - Use new v8::Message::GetLineNumber() API (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Patch Set: Created June 19, 2018, 5:13 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/JsError.cpp

===================================================================

--- a/src/JsError.cpp

+++ b/src/JsError.cpp

@@ -31,12 +31,16 @@

{

std::stringstream error;

error << *v8::String::Utf8Value(isolate, exception);

if (!message.IsEmpty())

{

error << " at ";

error << *v8::String::Utf8Value(isolate, message->GetScriptResourceName());

error << ":";

- error << message->GetLineNumber();

+ auto lineNumber = message->GetLineNumber(isolate->GetCurrentContext());

+ if (lineNumber.IsJust())

+ error << lineNumber.FromJust();

+ else

+ error << "<unknown>";

}

return error.str();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »