|
|
Created:
June 20, 2018, 1:33 p.m. by a.giammarchi Modified:
July 5, 2018, 10:08 a.m. Visibility:
Public. |
DescriptionAvoid retina images to be viewed too big, and preserve their HiDPi quality.
Patch Set 1 #Patch Set 2 : dropped spaces #MessagesTotal messages: 12
P.S. I guess my automatic eyeo CSS linting rules applier worked as expected, explaining those new lines between rules. It is consistent with the way we write CSS in eyeo, but those bother you, I can remove that.
Sorry for the confusion, i was thinking in "automation"-realms. However - Vasily should be the one reviewing this instead of myself, since he's the module owner. Added him to CC
On 2018/06/20 13:37:15, a.giammarchi wrote: > P.S. I guess my automatic eyeo CSS linting rules applier worked as expected, > explaining those new lines between rules. > > It is consistent with the way we write CSS in eyeo, but those bother you, I can > remove that. I think it would be better to make another Noissue commit for CSS formatting changes. Otherwise this looks good.
On 2018/06/21 09:54:21, Vasily Kuznetsov wrote: > On 2018/06/20 13:37:15, a.giammarchi wrote: > > P.S. I guess my automatic eyeo CSS linting rules applier worked as expected, > > explaining those new lines between rules. > > > > It is consistent with the way we write CSS in eyeo, but those bother you, I > can > > remove that. > > I think it would be better to make another Noissue commit for CSS formatting > changes. Otherwise this looks good. Done
LGTM
On 2018/06/21 12:40:40, Vasily Kuznetsov wrote: > LGTM Thanks. How do we proceed now? Not sure I have rights to push this.
On 2018/06/21 13:05:49, a.giammarchi wrote: > On 2018/06/21 12:40:40, Vasily Kuznetsov wrote: > > LGTM > > Thanks. How do we proceed now? Not sure I have rights to push this. It would be nice if Thomas has a look at this, if he has a minute, as I'm no CSS expert, but otherwise you can just send the change to me and I will push it.
No problem. LGTM
On 2018/06/21 15:21:24, Thomas Greiner wrote: > No problem. > > LGTM Thank you, Thomas. Andrea, I can push the patch directly from this review. What email address should I use as committer name? Is "Andrea Giammarchi <andrea@adblockplus.org>" correct?
On 2018/06/21 15:54:12, Vasily Kuznetsov wrote: > On 2018/06/21 15:21:24, Thomas Greiner wrote: > > No problem. > > > > LGTM > > Thank you, Thomas. > > Andrea, I can push the patch directly from this review. What email address > should I use as committer name? Is "Andrea Giammarchi <mailto:andrea@adblockplus.org>" > correct? that one or a.giammarchi@eyeo.com would do (the one I think I use the most). Thanks!
On 2018/06/21 21:02:53, a.giammarchi wrote: > On 2018/06/21 15:54:12, Vasily Kuznetsov wrote: > > On 2018/06/21 15:21:24, Thomas Greiner wrote: > > > No problem. > > > > > > LGTM > > > > Thank you, Thomas. > > > > Andrea, I can push the patch directly from this review. What email address > > should I use as committer name? Is "Andrea Giammarchi > <mailto:andrea@adblockplus.org>" > > correct? > > that one or mailto:a.giammarchi@eyeo.com would do (the one I think I use the most). > > Thanks! I pushed this, using a.giammarchi@eyeo.com address.
On 2018/06/22 13:58:17, Vasily Kuznetsov wrote: > On 2018/06/21 21:02:53, a.giammarchi wrote: > > On 2018/06/21 15:54:12, Vasily Kuznetsov wrote: > > > On 2018/06/21 15:21:24, Thomas Greiner wrote: > > > > No problem. > > > > > > > > LGTM > > > > > > Thank you, Thomas. > > > > > > Andrea, I can push the patch directly from this review. What email address > > > should I use as committer name? Is "Andrea Giammarchi > > <mailto:andrea@adblockplus.org>" > > > correct? > > > > that one or mailto:a.giammarchi@eyeo.com would do (the one I think I use the > most). > > > > Thanks! > > I pushed this, using mailto:a.giammarchi@eyeo.com address. Thank you !!! |