Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: includes/footer.tmpl

Issue 29812593: Fixes #99 - Added social media anchor titles, images alt text, and header to footer locale file (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Created June 21, 2018, 12:11 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | locales/en/footer.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% from "macros/pageitem" import pageitem %} 1 {% from "macros/pageitem" import pageitem %}
2 2
3 <footer id="footer" class="content"> 3 <footer id="footer" class="content">
4 <div class="container"> 4 <div class="container">
5 <div class="row"> 5 <div class="row">
6 <nav class="column one-fourth"> 6 <nav class="column one-fourth">
7 <h5>{{ get_string("resources", "menu") }}</h5> 7 <h5>{{ get_string("resources", "menu") }}</h5>
8 <ul> 8 <ul>
9 {% for pagename in ["acceptable-ads", "documentation", "deployments", "bugs"] %} 9 {% for pagename in ["acceptable-ads", "documentation", "deployments", "bugs"] %}
10 <li>{{ pagename | linkify }}{{ get_string(pagename, "menu") }}</a></ li> 10 <li>{{ pagename | linkify }}{{ get_string(pagename, "menu") }}</a></ li>
(...skipping 11 matching lines...) Expand all
22 </nav> 22 </nav>
23 <nav class="column one-fourth"> 23 <nav class="column one-fourth">
24 <h5>{{get_string("development", "menu")}}</h5> 24 <h5>{{get_string("development", "menu")}}</h5>
25 <ul> 25 <ul>
26 {{ pageitem("source") }} 26 {{ pageitem("source") }}
27 <li><a href="https://issues.adblockplus.org/report/13" hreflang="en">{ { get_string("roadmap", "menu") }}</a></li> 27 <li><a href="https://issues.adblockplus.org/report/13" hreflang="en">{ { get_string("roadmap", "menu") }}</a></li>
28 {{ pageitem("tools") }} 28 {{ pageitem("tools") }}
29 <li><a href="https://eyeo.com/jobs/" hreflang="en">{{ get_string("jobs ", "menu") }}</a></li> 29 <li><a href="https://eyeo.com/jobs/" hreflang="en">{{ get_string("jobs ", "menu") }}</a></li>
30 </ul> 30 </ul>
31 </nav> 31 </nav>
32
32 <nav id="social-list" class="column one-fourth"> 33 <nav id="social-list" class="column one-fourth">
33 <h5>{{get_string("follow-us", "menu")}}</h5> 34 <h5>{{get_string("follow-us-header", "footer")}}</h5>
34 <ul> 35 <ul>
35 <li> 36 <li>
36 <a href="https://twitter.com/AdblockPlus" target="_blank"> 37 <a
38 href="https://twitter.com/AdblockPlus"
39 title="{{ get_string("twitter-title", "footer") }}"
40 target="_blank">
37 <img 41 <img
38 src="/img/footer-twitter-glyphicon.png" 42 src="/img/footer-twitter-glyphicon.png"
39 alt="{{ "Twitter" | translate("twitter-alt", "Twitter glyphicon alt text")}}"> 43 alt="{{ get_string("twitter-alt", "footer") }}">
40 </a> 44 </a>
41 </li> 45 </li>
42 <li> 46 <li>
43 <a href="https://www.youtube.com/user/AdblockPlusOfficial" target="_ blank"> 47 <a
44 <img src="/img/footer-youtube-glyphicon.png"> 48 href="https://www.youtube.com/user/AdblockPlusOfficial"
49 title="{{ get_string("youtube-title", "footer") }}"
50 target="_blank">
51 <img
52 src="/img/footer-youtube-glyphicon.png"
53 alt="{{ get_string("youtube-alt", "footer") }}">
45 </a> 54 </a>
46 </li> 55 </li>
47 <li> 56 <li>
48 <a href="https://www.facebook.com/adblockplus" target="_blank"> 57 <a
49 <img src="/img/footer-facebook-glyphicon.png"> 58 href="https://www.facebook.com/adblockplus"
59 title="{{ get_string("facebook-title", "footer") }}"
60 target="_blank">
61 <img
62 src="/img/footer-facebook-glyphicon.png"
63 alt="{{ get_string("facebook-alt", "footer") }}">
50 </a> 64 </a>
51 </li> 65 </li>
52 <li> 66 <li>
53 <a href="https://www.instagram.com/adblockplus/" target="_blank"> 67 <a
54 <img src="/img/footer-instagram-glyphicon.png"> 68 href="https://www.instagram.com/adblockplus/"
69 title="{{ get_string("instagram-title", "footer") }}"
70 target="_blank">
71 <img
72 src="/img/footer-instagram-glyphicon.png"
73 alt="{{ get_string("instagram-alt", "footer") }}">
55 </a> 74 </a>
56 </li> 75 </li>
57 </ul> 76 </ul>
58 </nav> 77 </nav>
59 </div> {# .row #} 78 </div> {# .row #}
79
60 <div id="footer-legal"> 80 <div id="footer-legal">
61 <p id="copyright-notice">{{ get_string("copyright", "footer") }}</p> 81 <p id="copyright-notice">{{ get_string("copyright", "footer") }}</p>
62 <ul id="legal-list"> 82 <ul id="legal-list">
63 {% for pagename in ["terms", "privacy", "impressum"] %} 83 {% for pagename in ["terms", "privacy", "impressum"] %}
64 <li>{{ pagename | linkify }}{{ get_string(pagename, "menu") }}</a></li > 84 <li>{{ pagename | linkify }}{{ get_string(pagename, "menu") }}</a></li >
65 {% endfor %} 85 {% endfor %}
66 </ul> 86 </ul>
67 </div> {# #footer-legal #} 87 </div> {# #footer-legal #}
68 </div> {# .container #} 88 </div> {# .container #}
69 </footer> {# #footer #} 89 </footer> {# #footer #}
OLDNEW
« no previous file with comments | « no previous file | locales/en/footer.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld