Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29812593: Fixes #99 - Added social media anchor titles, images alt text, and header to footer locale file (Closed)

Created:
June 21, 2018, 12:11 p.m. by juliandoucette
Modified:
June 22, 2018, 11:58 a.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

This applies to the index_page bookmark after https://codereview.adblockplus.org/29812589/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -9 lines) Patch
M includes/footer.tmpl View 1 chunk +29 lines, -9 lines 0 comments Download
M locales/en/footer.json View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 6
juliandoucette
June 21, 2018, 12:11 p.m. (2018-06-21 12:11:55 UTC) #1
juliandoucette
On 2018/06/21 12:11:55, juliandoucette wrote: I forgot to mention "This applies to the index_page bookmark ...
June 21, 2018, 3:32 p.m. (2018-06-21 15:32:39 UTC) #2
ire
The patch doesn't apply :( But the code looks good from here
June 21, 2018, 3:38 p.m. (2018-06-21 15:38:10 UTC) #3
ire
On 2018/06/21 15:32:39, juliandoucette wrote: > On 2018/06/21 12:11:55, juliandoucette wrote: > > I forgot ...
June 21, 2018, 3:38 p.m. (2018-06-21 15:38:49 UTC) #4
ire
LGTM
June 21, 2018, 3:43 p.m. (2018-06-21 15:43:51 UTC) #5
juliandoucette
June 22, 2018, 11:58 a.m. (2018-06-22 11:58:36 UTC) #6
On 2018/06/21 15:43:51, ire wrote:
> LGTM

Done https://hg.adblockplus.org/web.adblockplus.org/rev/47b96059a78c.

Powered by Google App Engine
This is Rietveld