Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: README.md

Issue 29812630: Issue 6750 - Update libadblockplus dependency to revision hg:4f6413dbcf2e (Closed)
Left Patch Set: Updated versions Created June 22, 2018, 7:24 a.m.
Right Patch Set: addressed Sergey comments. Created June 22, 2018, 11:18 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « .hgignore ('k') | adblock-android-settings/build.gradle » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 Adblock Android SDK 1 Adblock Android SDK
2 ================================ 2 ================================
3 3
4 An Android library project, tests, settings fragments and demo application for A dblockWebView. 4 An Android library project, tests, settings fragments and demo application for A dblockWebView.
5 5
6 ## Updating the dependencies 6 ## Updating the dependencies
7 7
8 Adblock Android SDK has dependencies that aren't in this repository. 8 Adblock Android SDK has dependencies that aren't in this repository.
9 To update those, call: 9 To update those, call:
10 10
11 ./ensure_dependencies.py 11 ./ensure_dependencies.py
12 12
13 ## Library 13 ## Library
14 14
15 An Android library that provides the core functionality of Adblock Plus. 15 An Android library that provides the core functionality of Adblock Plus.
16 You can find it in the 'adblock-android' directory. 16 You can find it in the 'adblock-android' directory.
17 17
18 ### Building 18 ### Building
19 19
20 #### Requirements 20 #### Requirements
21 21
22 * [The Android SDK](https://developer.android.com/sdk) 22 * [The Android SDK](https://developer.android.com/sdk)
23 * Android SDK Build tools 25.0.0 23 * Android SDK Build tools 25.0.0
24 * [The Android NDK, 16b](https://developer.android.com/ndk) 24 * [The Android NDK, 16b](https://developer.android.com/ndk)
25 25
26 Edit 'buildToolsVersion' in 'build.gradle' files if necessary. 26 Edit 'buildToolsVersion' in 'build.gradle' files if necessary.
27 27
28 #### Building of libadblockplus 28 #### Building of libadblockplus
29 29
30 First, we need to build `V8` required for `libadblockplus`. 30 First, we need to build `V8` required for `libadblockplus`.
sergei 2018/06/22 09:21:16 Perhaps later we could incorporate either in libab
anton 2018/06/22 10:58:18 "proper" way would be to compile `libadblockplus`
31 See `libadblockplus/README` or V8 documentation on how to build V8 or 31 See `libadblockplus/README` or V8 documentation on how to build V8 or
32 fetch precompiled one. Run in 'libadblockplus' directory: 32 fetch precompiled one. For the latter, run in 'libadblockplus' directory:
sergei 2018/06/22 09:21:16 I would say, "For the latter, run in 'libad...."
anton 2018/06/22 10:58:18 Acknowledged.
33 33
34 make TARGET_OS=android ABP_TARGET_ARCH=arm Configuration=release get-prebuil t-v8 34 make TARGET_OS=android ABP_TARGET_ARCH=arm Configuration=release get-prebuil t-v8
35 make TARGET_OS=android ABP_TARGET_ARCH=ia32 Configuration=release get-prebui lt-v8 35 make TARGET_OS=android ABP_TARGET_ARCH=ia32 Configuration=release get-prebui lt-v8
sergei 2018/06/22 09:21:16 what about arm64?
anton 2018/06/22 10:58:17 It's not yet supported.
36 36
37 Then we can build `libadblockplus`: 37 Then we can build `libadblockplus`:
38 38
39 make TARGET_OS=android ABP_TARGET_ARCH=arm Configuration=release 39 make TARGET_OS=android ABP_TARGET_ARCH=arm Configuration=release
40 make TARGET_OS=android ABP_TARGET_ARCH=ia32 Configuration=release 40 make TARGET_OS=android ABP_TARGET_ARCH=ia32 Configuration=release
41 41
42 #### Building from command-line 42 #### Building from command-line
43 43
44 In the project root directory create the file _local.properties_ and set 44 In the project root directory create the file _local.properties_ and set
45 _sdk.dir_ and _ndk.dir_ to where you installed it, e.g.: 45 _sdk.dir_ and _ndk.dir_ to where you installed it, e.g.:
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 274
275 ### Building 275 ### Building
276 276
277 Make sure _Library_ requirements are present. 277 Make sure _Library_ requirements are present.
278 278
279 In the project root directory run: 279 In the project root directory run:
280 280
281 ./gradlew assemble 281 ./gradlew assemble
282 282
283 This will generate *.apk in the 'adblock-android-webviewapp/build/outputs/apk/' directory. 283 This will generate *.apk in the 'adblock-android-webviewapp/build/outputs/apk/' directory.
LEFTRIGHT

Powered by Google App Engine
This is Rietveld