Issue 6750 - Update libadblockplus dependency to revision hg:4f6413dbcf2e

Issue 6750 - Update libadblockplus dependency to revision hg:4f6413dbcf2e

This is replacement for code review https://codereview.adblockplus.org/29810565/ which is LGTMed and has pretty the same.

I've figured out that i've applied it to not the most recent version of libadblockplus so some paths are changed (eg. `libadblockplus-android` renamed to `adblockplus-android`). Also i've renamed the ticket and replaced libadblockplus revisions.

[jens, 2018-06-22 07:07:09]

LGTM

https://codereview.adblockplus.org/29812630/diff/29812639/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29812630/diff/29812639/dependencies#newcode4
dependencies:4: libadblockplus = libadblockplus hg:4f6413dbcf2e
git:40f5d4d2d00abe3f94ce69210267bcce908cd748
Since I can not leave a comment in the overview: LGTM

[sergei, 2018-06-22 09:21:17]

LGTM

https://codereview.adblockplus.org/29812630/diff/29813555/README.md
File README.md (right):

https://codereview.adblockplus.org/29812630/diff/29813555/README.md#newcode30
README.md:30: First, we need to build `V8` required for `libadblockplus`.
Perhaps later we could incorporate either in libabp or in gradle the
functionality which can guess whether the V8 should be fetched and does it. So,
in order to build it, one has to merely run one command ./gradlew
assembleRelease or its moral equivalent.

https://codereview.adblockplus.org/29812630/diff/29813555/README.md#newcode32
README.md:32: fetch precompiled one. Run in 'libadblockplus' directory:
I would say, "For the latter, run in 'libad...."

https://codereview.adblockplus.org/29812630/diff/29813555/README.md#newcode35
README.md:35: make TARGET_OS=android ABP_TARGET_ARCH=ia32 Configuration=release
get-prebuilt-v8
what about arm64?

https://codereview.adblockplus.org/29812630/diff/29813555/dependencies
File dependencies (left):

https://codereview.adblockplus.org/29812630/diff/29813555/dependencies#oldcode4
dependencies:4: adblock-android/jni/libadblockplus-binaries =
libadblockplus-binaries hg:53ac7bd55f26
git:1b83d9fe0524ee1faf4c13acadd06efac184a768
should we now deprecate libadblockplus-binaries repository?

[anton, 2018-06-22 10:58:18]

https://codereview.adblockplus.org/29812630/diff/29813555/README.md
File README.md (right):

https://codereview.adblockplus.org/29812630/diff/29813555/README.md#newcode30
README.md:30: First, we need to build `V8` required for `libadblockplus`.
On 2018/06/22 09:21:16, sergei wrote:
> Perhaps later we could incorporate either in libabp or in gradle the
> functionality which can guess whether the V8 should be fetched and does it.
So,
> in order to build it, one has to merely run one command ./gradlew
> assembleRelease or its moral equivalent.

"proper" way would be to compile `libadblockplus` as gradle/maven module, push
it to some public repository and add dependency to the module and let gralde
download it automatically. This should be done while building of
`libadblockplus`.

https://codereview.adblockplus.org/29812630/diff/29813555/README.md#newcode32
README.md:32: fetch precompiled one. Run in 'libadblockplus' directory:
On 2018/06/22 09:21:16, sergei wrote:
> I would say, "For the latter, run in 'libad...."

Acknowledged.

https://codereview.adblockplus.org/29812630/diff/29813555/README.md#newcode35
README.md:35: make TARGET_OS=android ABP_TARGET_ARCH=ia32 Configuration=release
get-prebuilt-v8
On 2018/06/22 09:21:16, sergei wrote:
> what about arm64?

It's not yet supported.

https://codereview.adblockplus.org/29812630/diff/29813555/dependencies
File dependencies (left):

https://codereview.adblockplus.org/29812630/diff/29813555/dependencies#oldcode4
dependencies:4: adblock-android/jni/libadblockplus-binaries =
libadblockplus-binaries hg:53ac7bd55f26
git:1b83d9fe0524ee1faf4c13acadd06efac184a768
On 2018/06/22 09:21:16, sergei wrote:
> should we now deprecate libadblockplus-binaries repository?

yes, we should but it should be still available for some time.

[sergei, 2018-06-22 11:24:58]

LGTM