Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29812630: Issue 6750 - Update libadblockplus dependency to revision hg:4f6413dbcf2e (Closed)
Patch Set: Updated Android.mk because of different dirs per prebuilt libs. Created June 21, 2018, 6:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | adblock-android/jni/Android.mk » ('j') | dependencies » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
diff --git a/README.md b/README.md
index ef024ba90c553ef4034d31409d54f672a5da5b2c..3a3e5405a528caa44d0e64aebbf7f54b7ad1ce3b 100644
--- a/README.md
+++ b/README.md
@@ -25,6 +25,20 @@ You can find it in the 'adblock-android' directory.
Edit 'buildToolsVersion' in 'build.gradle' files if necessary.
+#### Building of libadblockplus
+
+First, we need to build `V8` required for `libadblockplus`.
+See `libadblockplus/README` or V8 documentation on how to build V8 or
+fetch precompiled one. Run in 'libadblockplus' directory:
+
+ make TARGET_OS=android ABP_TARGET_ARCH=arm Configuration=release get-prebuilt-v8
+ make TARGET_OS=android ABP_TARGET_ARCH=ia32 Configuration=release get-prebuilt-v8
+
+Then we can build `libadblockplus`:
+
+ make TARGET_OS=android ABP_TARGET_ARCH=arm Configuration=release
+ make TARGET_OS=android ABP_TARGET_ARCH=ia32 Configuration=release
+
#### Building from command-line
In the project root directory create the file _local.properties_ and set
@@ -65,16 +79,17 @@ output while building
This can be desired to use product's V8 (let's say Chromium) instead of built-in V8.
Put prebuilt shared V8 library file(s) in ARCH directories and set `SHARED_V8_LIB_FILENAMES`
-environment variable before building. You can pass multiple filenames, separated with space.
+environment variable and `SHARED_V8_LIB_DIR` before building.
+You can pass multiple filenames in `SHARED_V8_LIB_FILENAMES`, separated with space.
Libadblockplus is required to be linked with that library file(s).
For example:
- SHARED_V8_LIB_FILENAMES=libv8.cr.so ./gradlew clean assemble
+ SHARED_V8_LIB_FILENAMES=libv8.cr.so SHARED_V8_LIB_DIR="/tmp/shared_v8" ./gradlew clean assembleAbi_arm
or
- SHARED_V8_LIB_FILENAMES="libv8.cr.so libfoo.so" ./gradlew clean assemble
+ SHARED_V8_LIB_FILENAMES="libv8.cr.so libv8_libbase.cr.so libv8_libplatform.cr.so" SHARED_V8_LIB_DIR="/tmp/shared_v8" ./gradlew clean assembleAbi_arm
for multiple library files.
@@ -82,14 +97,11 @@ Note
[Configuration] Excluding shared v8 library libv8.cr.so from AAR
...
- [Configuration] Linking dynamically with shared v8 library ./libadblockplus-binaries/android_armeabi-v7a/libv8.cr.so
+ [Configuration] Linking dynamically with shared v8 library /tmp/shared_v8/release/libv8.cr.so
...
output while building.
-Set `SHARED_V8_LIB_DIR` environment variable as full absolute path to pass
-specific directory instead of default one (`adblock-android/jni/libadblockplus-binaries`).
-
### Building for single ARCH
By default adblock-android is built for both ARM and x86 and it can be filtered when
« no previous file with comments | « no previous file | adblock-android/jni/Android.mk » ('j') | dependencies » ('J')

Powered by Google App Engine
This is Rietveld