Issue 29812643: #12104 - Fixed blocked in-feed ads

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29812643: #12104 - Fixed blocked in-feed ads (Closed)

Created:
June 21, 2018, 7:15 p.m. by kzar

Modified:
July 5, 2018, 9:56 a.m.

Reviewers:
arthur

Visibility:
Public.

Description

#12104 - Fixed blocked in-feed ads

Patch Set 1 #

Created: June 21, 2018, 7:15 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	easylist+exceptionrules_content_blocker.json	View		2 chunks	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

kzar

Patch Set 1 This is for C13548 which https://hg.adblockplus.org/contentblockerlists/rev/347c671adac7 was supposed to fix. I'm away ...

June 21, 2018, 7:19 p.m. (2018-06-21 19:19:47 UTC) #1

arthur

June 22, 2018, 4:27 p.m. (2018-06-22 16:27:34 UTC) #2

On 2018/06/21 19:19:47, kzar wrote:
> Patch Set 1
> 
> This is for C13548 which
> https://hg.adblockplus.org/contentblockerlists/rev/347c671adac7 was supposed
to
> fix.
> 
> I'm away for a few days now so if this change works for you as well feel free
to
> push it for me or even just commit it in your name. I don't mind. Otherwise I
> can push it Tuesday for you.

LGTM

Expand All Messages | Collapse All Messages