Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/JsValue.cpp

Issue 29813591: Issue 6526 - Use Maybe<> version of soon to be deprecated API in v8 6.7 (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created June 22, 2018, 8:54 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/JsValue.cpp ('K') | « src/Utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/JsValue.cpp
===================================================================
--- a/test/JsValue.cpp
+++ b/test/JsValue.cpp
@@ -206,17 +206,17 @@
}
TEST_F(JsValueTest, JsValueCallSingleArg)
{
auto func = GetJsEngine().Evaluate("(function(arg) {return arg * 2;})");
EXPECT_EQ(10, func.Call(GetJsEngine().NewValue(5)).AsInt());
}
-TEST_F(JsValueTest, ThrowingCoversion)
+TEST_F(JsValueTest, ThrowingConversion)
sergei 2018/08/07 13:14:51 It's unrelated but OK.
{
const std::string source("\
function Foo() {\
this.toString = function() {throw 'test1';};\
this.valueOf = function() {throw 'test2';};\
};\
new Foo()");
auto value = GetJsEngine().Evaluate(source);
« src/JsValue.cpp ('K') | « src/Utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld