Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(568)

Issue 29823572: Noissue - add unit-test to check that renameFile works as expected by FilterStorage.js (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by sergei
Modified:
1 month ago
Reviewers:
hub
Base URL:
https://github.com/adblockplus/libadblockplus@d361cdf75c6c5af2aaa9b484092ded6c0a1dc441
Visibility:
Public.

Description

# Since we had doubts that there can be some issue, here is the test to ensure that JS part works as expected in FilterStorage.js.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M test/FileSystemJsObject.cpp View 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 3
sergei
To tell the truth, I'm not sure that it is worth committing, but perhaps more ...
2 months, 2 weeks ago (2018-07-05 10:09:20 UTC) #1
hub
more test covrage is always good. LGTM
2 months, 1 week ago (2018-07-10 17:25:08 UTC) #2
sergei
1 month ago (2018-08-20 10:16:26 UTC) #3
Closing without landing because it's migrated to gitlab
https://gitlab.com/eyeo/adblockplus/libadblockplus/merge_requests/13. Will be
landed as soon as we agree on the merging policy.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5