Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29823575: Noissue - fix the switching to clang++/libc++ (Closed)

Created:
July 5, 2018, 10:10 a.m. by sergei
Modified:
July 10, 2018, 1:38 p.m.
Reviewers:
hub
Base URL:
https://github.com/adblockplus/libadblockplus@ca063256d589c9e950a5b14a16bc266e3b5072e8
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M Makefile View 1 2 chunks +7 lines, -2 lines 1 comment Download

Messages

Total messages: 3
sergei
https://codereview.adblockplus.org/29823575/diff/29823576/Makefile File Makefile (right): https://codereview.adblockplus.org/29823575/diff/29823576/Makefile#newcode108 Makefile:108: $(MAKE) -C ${BUILD_DIR} ${SUB_ACTION} ${CXX_PARAM} It's not enough to ...
July 5, 2018, 10:29 a.m. (2018-07-05 10:29:34 UTC) #1
sergei
July 5, 2018, 10:29 a.m. (2018-07-05 10:29:48 UTC) #2
hub
July 10, 2018, 1:22 p.m. (2018-07-10 13:22:59 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld