Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29824575: Issue 6689 - Add type property to Subscription class (Closed)

Created:
July 6, 2018, 2:27 p.m. by Manish Jethani
Modified:
July 9, 2018, 8 a.m.
Reviewers:
hub
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M lib/subscriptionClasses.js View 3 chunks +10 lines, -0 lines 0 comments Download
M test/subscriptionClasses.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
Manish Jethani
July 6, 2018, 2:27 p.m. (2018-07-06 14:27:49 UTC) #1
Manish Jethani
Patch Set 1
July 6, 2018, 2:28 p.m. (2018-07-06 14:28:44 UTC) #2
hub
I'm not sure why you tackled this one. While I didn't submit the patch for ...
July 8, 2018, 1:48 p.m. (2018-07-08 13:48:15 UTC) #3
hub
ok, I see now. You need it for snippets. LGTM
July 8, 2018, 7:42 p.m. (2018-07-08 19:42:27 UTC) #4
Manish Jethani
July 9, 2018, 7:56 a.m. (2018-07-09 07:56:46 UTC) #5
On 2018/07/08 19:42:27, hub wrote:
> ok, I see now. 
> 
> You need it for snippets.

Yeah, I kinda need it for Snippets.

> LGTM

Thanks!

Powered by Google App Engine
This is Rietveld