Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29825674: Noissue - Moved abp2blocklist to "Adblock Plus for iOS/macOS" module (Closed)

Created:
July 9, 2018, 4:37 p.m. by Sebastian Noack
Modified:
July 10, 2018, 3:53 p.m.
Reviewers:
d108, kzar, juliandoucette
CC:
Felix Dahlke
Visibility:
Public.

Description

Noissue - Moved abp2blocklist to "Adblock Plus for iOS/macOS" module

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pages/modules.html View 3 chunks +4 lines, -4 lines 2 comments Download

Messages

Total messages: 5
Sebastian Noack
With Adblock Plus for Safari on the way out, Adblock Plus for iOS/macOS will be ...
July 9, 2018, 4:40 p.m. (2018-07-09 16:40:37 UTC) #1
d108
On 2018/07/09 16:40:37, Sebastian Noack wrote: > With Adblock Plus for Safari on the way ...
July 9, 2018, 5:26 p.m. (2018-07-09 17:26:19 UTC) #2
kzar
LGTM
July 9, 2018, 6:06 p.m. (2018-07-09 18:06:25 UTC) #3
juliandoucette
LGTM + NIT https://codereview.adblockplus.org/29825674/diff/29825675/pages/modules.html File pages/modules.html (right): https://codereview.adblockplus.org/29825674/diff/29825675/pages/modules.html#newcode370 pages/modules.html:370: <td>Adblock Plus for iOS/macOS</td> NIT: Isn't ...
July 10, 2018, 11:50 a.m. (2018-07-10 11:50:43 UTC) #4
kzar
July 10, 2018, 12:27 p.m. (2018-07-10 12:27:32 UTC) #5
https://codereview.adblockplus.org/29825674/diff/29825675/pages/modules.html
File pages/modules.html (right):

https://codereview.adblockplus.org/29825674/diff/29825675/pages/modules.html#...
pages/modules.html:370: <td>Adblock Plus for iOS/macOS</td>
On 2018/07/10 11:50:43, juliandoucette wrote:
> NIT: Isn't it called "OS X"?

It used to be, but they renamed it a while back.
https://www.wired.com/2016/06/apple-os-x-dead-long-live-macos/

Powered by Google App Engine
This is Rietveld