Issue 29827630: Issue 6689 - Added anti-CV filter list subscription

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29827630: Issue 6689 - Added anti-CV filter list subscription (Closed)

Created:
July 11, 2018, 3:07 p.m. by hub

Modified:
July 11, 2018, 4:47 p.m.

Reviewers:
Manish Jethani, kzar

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Issue 6689 - Added anti-CV filter list subscription

Patch Set 1 #

Total comments: 1

Created: July 11, 2018, 3:07 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/content/ui/subscriptions.xml	View		1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hub

this file is regenerated from the subscriptionlist repository.

July 11, 2018, 3:08 p.m. (2018-07-11 15:08:17 UTC) #2

Manish Jethani

July 11, 2018, 3:21 p.m. (2018-07-11 15:21:34 UTC) #3

LGTM

https://codereview.adblockplus.org/29827630/diff/29827631/chrome/content/ui/s...
File chrome/content/ui/subscriptions.xml (right):

https://codereview.adblockplus.org/29827630/diff/29827631/chrome/content/ui/s...
chrome/content/ui/subscriptions.xml:149:
url="https://easylist-downloads.adblockplus.org/abp-filters-anti-cv.txt"
To keep all the naming consistent, shouldn't this have been
abp-filters-circumvention rather than abp-filters-anti-cv?

Anyway I guess I missed the boat on this one.

Expand All Messages | Collapse All Messages