Issue 29827633: Issue 6538, 6781 - Add initial snippets library

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29827633: Issue 6538, 6781 - Add initial snippets library (Closed)

Created:
July 11, 2018, 3:49 p.m. by Manish Jethani

Modified:
July 11, 2018, 5:59 p.m.

Reviewers:
kzar, hub

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

This is the initial version of the snippets library. It contains only one snippet called "log", which can be used for debugging purposes. adblockpluschrome will include this file similar to the way it includes lib/content/elemHideEmulation.js Eventually the snippets library will have its own repo.

Patch Set 1 #

Created: July 11, 2018, 3:49 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -0 lines)			Patch
	A	lib/content/snippets.js	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kzar

We know that `args` will always be an empty array, or an array of strings ...

July 11, 2018, 5:47 p.m. (2018-07-11 17:47:12 UTC) #3

Manish Jethani

July 11, 2018, 5:58 p.m. (2018-07-11 17:58:51 UTC) #4

On 2018/07/11 17:47:12, kzar wrote:
> We know that `args` will always be an empty array, or an array of strings
right?

Yes, zero or more elements in the array, and each element is guaranteed (by the
other part of the implementation) to be a string.

> If so LGTM.

Thanks!

Expand All Messages | Collapse All Messages