Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29828591: Issue 6787 - Apply rewrite filter even if the rewrite URL is blank (Closed)

Created:
July 12, 2018, 11:39 a.m. by Manish Jethani
Modified:
July 12, 2018, 1:05 p.m.
Reviewers:
Sebastian Noack, kzar
CC:
hub
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 6787 - Apply rewrite filter even if the rewrite URL is blank

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use typeof instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/requestBlocker.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Manish Jethani
July 12, 2018, 11:39 a.m. (2018-07-12 11:39:24 UTC) #1
Manish Jethani
Patch Set 1
July 12, 2018, 11:40 a.m. (2018-07-12 11:40:10 UTC) #2
kzar
https://codereview.adblockplus.org/29828591/diff/29828592/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/29828591/diff/29828592/lib/requestBlocker.js#newcode197 lib/requestBlocker.js:197: if (filter.rewrite != null) Nit: I think I'd prefer ...
July 12, 2018, 12:02 p.m. (2018-07-12 12:02:13 UTC) #3
Manish Jethani
Patch Set 2: Use typeof instead https://codereview.adblockplus.org/29828591/diff/29828592/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/29828591/diff/29828592/lib/requestBlocker.js#newcode197 lib/requestBlocker.js:197: if (filter.rewrite != ...
July 12, 2018, 12:06 p.m. (2018-07-12 12:06:28 UTC) #4
kzar
July 12, 2018, 12:58 p.m. (2018-07-12 12:58:07 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld