Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(267)

Issue 29828594: Issue 6785 - Implement chinese translations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by jens
Modified:
1 year ago
Reviewers:
anton, diegocarloslima
Visibility:
Public.

Description

Issue 6785 - Implement chinese translations

Patch Set 1 #

Patch Set 2 : adjusted values folder name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
A adblockplussbrowser/res/values-zh-rCN/strings.xml View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jens
1 year, 1 month ago (2018-07-12 11:50:44 UTC) #1
anton
On 2018/07/12 11:50:44, jens wrote: Should it work for all the regions? AFAIK they can ...
1 year, 1 month ago (2018-07-12 11:56:00 UTC) #2
jens
On 2018/07/12 11:56:00, anton wrote: > On 2018/07/12 11:50:44, jens wrote: > > Should it ...
1 year, 1 month ago (2018-07-12 12:08:35 UTC) #3
anton
On 2018/07/12 12:08:35, jens wrote: > On 2018/07/12 11:56:00, anton wrote: > > On 2018/07/12 ...
1 year, 1 month ago (2018-07-12 12:17:37 UTC) #4
diegocarloslima
1 year, 1 month ago (2018-07-17 09:45:07 UTC) #5
On 2018/07/12 12:17:37, anton wrote:
> On 2018/07/12 12:08:35, jens wrote:
> > On 2018/07/12 11:56:00, anton wrote:
> > > On 2018/07/12 11:50:44, jens wrote:
> > > 
> > > Should it work for all the regions? AFAIK they can be different.
> > > In libadblockplus-android there are 2 regions for Chinese:
> > >
> >
>
https://github.com/adblockplus/libadblockplus-android/tree/master/adblock-and...
> > 
> > Checked with vicky, it's simplified chinese. I adjusted the folder
accordingly
> > and uploaded a new patch set.
> 
> LGTM

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5