Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29828594: Issue 6785 - Implement chinese translations (Closed)

Created:
July 12, 2018, 11:49 a.m. by jens
Modified:
July 25, 2018, 2:40 p.m.
Reviewers:
diegocarloslima, anton
Visibility:
Public.

Description

Issue 6785 - Implement chinese translations

Patch Set 1 #

Patch Set 2 : adjusted values folder name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
A adblockplussbrowser/res/values-zh-rCN/strings.xml View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jens
July 12, 2018, 11:50 a.m. (2018-07-12 11:50:44 UTC) #1
anton
On 2018/07/12 11:50:44, jens wrote: Should it work for all the regions? AFAIK they can ...
July 12, 2018, 11:56 a.m. (2018-07-12 11:56:00 UTC) #2
jens
On 2018/07/12 11:56:00, anton wrote: > On 2018/07/12 11:50:44, jens wrote: > > Should it ...
July 12, 2018, 12:08 p.m. (2018-07-12 12:08:35 UTC) #3
anton
On 2018/07/12 12:08:35, jens wrote: > On 2018/07/12 11:56:00, anton wrote: > > On 2018/07/12 ...
July 12, 2018, 12:17 p.m. (2018-07-12 12:17:37 UTC) #4
diegocarloslima
July 17, 2018, 9:45 a.m. (2018-07-17 09:45:07 UTC) #5
On 2018/07/12 12:17:37, anton wrote:
> On 2018/07/12 12:08:35, jens wrote:
> > On 2018/07/12 11:56:00, anton wrote:
> > > On 2018/07/12 11:50:44, jens wrote:
> > > 
> > > Should it work for all the regions? AFAIK they can be different.
> > > In libadblockplus-android there are 2 regions for Chinese:
> > >
> >
>
https://github.com/adblockplus/libadblockplus-android/tree/master/adblock-and...
> > 
> > Checked with vicky, it's simplified chinese. I adjusted the folder
accordingly
> > and uploaded a new patch set.
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld