Issue 29829581: Issue 6791 - Implement abort-current-inline-script snippet

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29829581: Issue 6791 - Implement abort-current-inline-script snippet (Closed)

Created:
July 13, 2018, 2:42 p.m. by Manish Jethani

Modified:
July 24, 2018, 3:49 p.m.

Reviewers:

CC:
hub, Sebastian Noack

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Based on https://codereview.adblockplus.org/29829569/

Patch Set 1 #

Created: July 13, 2018, 2:42 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -0 lines)			Patch
	M	lib/content/snippets.js	View		1 chunk	+108 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Manish Jethani

Patch Set 1 Opening a new review since the other one was rejected. This is ...

July 13, 2018, 2:44 p.m. (2018-07-13 14:44:52 UTC) #2

kzar

On 2018/07/13 14:44:52, Manish Jethani wrote: > Opening a new review since the other one ...

July 16, 2018, 2:37 p.m. (2018-07-16 14:37:03 UTC) #3

Manish Jethani

On 2018/07/16 14:37:03, kzar wrote: > On 2018/07/13 14:44:52, Manish Jethani wrote: > > Opening ...

July 17, 2018, 9:49 a.m. (2018-07-17 09:49:38 UTC) #4

kzar

July 17, 2018, 10:31 a.m. (2018-07-17 10:31:23 UTC) #5

On 2018/07/17 09:49:38, Manish Jethani wrote:
> > No need, we can carry on in the existing review
> > https://codereview.adblockplus.org/29828610/
> 
> I have withdrawn that patch because you said that it was "copied".

Well, perhaps read back through the discussion. I didn't say that the code was
copied. I received an email from someone outside of eyeo complaining that it was
copied, and so I asked you if you you wrote the code.

> This one is definitely not copied.  Please leave your comments here.

As you know, I have already left my comments on the other review yesterday. I
realise that you have closed the other review, but Rietveld allows you to
re-open reviews.

Expand All Messages | Collapse All Messages