Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29830555: Issue 6786 - Avoid running YouTube code on Safari 12+ (Closed)

Created:
July 15, 2018, 11:25 a.m. by kzar
Modified:
July 16, 2018, 11 a.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 6786 - Avoid running YouTube code on Safari 12+

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M safari/include.youtube.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
kzar
Patch Set 1 I just remembered about the YouTube content script. I don't _think_ it ...
July 15, 2018, 11:28 a.m. (2018-07-15 11:28:13 UTC) #1
Sebastian Noack
Well spotted. This could have caused Adblock Plus to be disabled when going to YouTube. ...
July 15, 2018, 1:30 p.m. (2018-07-15 13:30:56 UTC) #2
kzar
July 16, 2018, 11 a.m. (2018-07-16 11:00:04 UTC) #3
Message was sent while issue was closed.
Seems to work fine, so pushed it
https://hg.adblockplus.org/adblockpluschrome/rev/56f2bd3d981e

Powered by Google App Engine
This is Rietveld