Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29836555: Issue 6680 - PropsSelector also depend on DOM modifications (Closed)

Created:
July 23, 2018, 1:01 p.m. by hub
Modified:
July 24, 2018, 11:49 a.m.
Reviewers:
Manish Jethani, kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6680 - PropsSelector also depend on DOM modifications

Patch Set 1 #

Total comments: 8

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M lib/content/elemHideEmulation.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/browser/elemHideEmulation.js View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4
hub
July 23, 2018, 1:02 p.m. (2018-07-23 13:02:03 UTC) #1
Manish Jethani
Aside from the comments, LGTM Suggestion about the commit message: I would change it to ...
July 23, 2018, 8:44 p.m. (2018-07-23 20:44:01 UTC) #2
hub
https://codereview.adblockplus.org/29836555/diff/29836556/test/browser/elemHideEmulation.js File test/browser/elemHideEmulation.js (right): https://codereview.adblockplus.org/29836555/diff/29836556/test/browser/elemHideEmulation.js#newcode244 test/browser/elemHideEmulation.js:244: // On 2018/07/23 20:44:01, Manish Jethani wrote: > Nit: ...
July 23, 2018, 9:01 p.m. (2018-07-23 21:01:58 UTC) #3
Manish Jethani
July 23, 2018, 10:37 p.m. (2018-07-23 22:37:25 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld