Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29838555: Issue 6808 - Default to top frame of page if parent can't be found (Closed)

Created:
July 25, 2018, 7:12 p.m. by kzar
Modified:
July 25, 2018, 8:54 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 6808 - Default to top frame of page if parent can't be found

Patch Set 1 #

Total comments: 4

Patch Set 2 : Consistent > 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M ext/background.js View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
July 25, 2018, 7:13 p.m. (2018-07-25 19:13:32 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29838555/diff/29838556/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29838555/diff/29838556/ext/background.js#newcode538 ext/background.js:538: if (!frame.parent && detail.parentFrameId != 0) Why not falling ...
July 25, 2018, 7:31 p.m. (2018-07-25 19:31:25 UTC) #2
kzar
Patch Set 2 : Consistent > 0 https://codereview.adblockplus.org/29838555/diff/29838556/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29838555/diff/29838556/ext/background.js#newcode538 ext/background.js:538: if (!frame.parent ...
July 25, 2018, 8:28 p.m. (2018-07-25 20:28:26 UTC) #3
Sebastian Noack
July 25, 2018, 8:46 p.m. (2018-07-25 20:46:24 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld