includes/install-button-templates.tmpl - Issue 29841563: Noissue - Merged index_page into master

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/install-button-templates.tmpl

Issue 29841563: Noissue - Merged index_page into master (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Patch Set: Fixed more misc issues discussed in IRC Created July 30, 2018, 4:40 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 {% for browser in browsers %}

	2 <script id="download-label-{{ browser.id }}" type="text/template">

	3 {% if locale in ["en", "de", "fr"] %}

	4 {{ get_string("agree-and-install-for-" + browser.id, "install-button") }}

	5 {% else %}

	6 {{ get_string("install-for-" + browser.id, "install-button") }}

	7 {% endif %}

	8 </script>

	9 {% endfor %}
	ire 2018/07/31 00:10:08 NIT/Suggest: Is there a need to end and start 3 di NIT/Suggest: Is there a need to end and start 3 different for loops? Could we just have all the templates within the same for loop
	10

	11 {% for browser in browsers %}
	juliandoucette 2018/07/30 16:46:12 FIXME / Detail: I added these (temporarily) becaus FIXME / Detail: I added these (temporarily) because "install-for" strings were not being uploaded to crowdin. ire 2018/07/31 00:10:07 Acknowledged. Show quoted text On 2018/07/30 16:46:12, juliandoucette wrote: > FIXME / Detail: I added these (temporarily) because "install-for" strings were > not being uploaded to crowdin. Acknowledged.
	12 <script id="install-label-{{ browser.id }}" type="text/template">

	13 {{ get_string("install-for-" + browser.id, "install-button") }}

	14 </script>

	15 {% endfor %}

	16

	17 {% for browser in browsers %}

	18 <script id="agree-and-install-label-{{ browser.id }}" type="text/template">

	19 {{ get_string("agree-and-install-for-" + browser.id, "install-button") }}

	20 </script>

	21 {% endfor %}

OLD	NEW