Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29841563: Noissue - Merged index_page into master (Closed)

Created:
July 30, 2018, 3:47 a.m. by juliandoucette
Modified:
Aug. 3, 2018, 5:47 a.m.
Reviewers:
ire
CC:
saroyanm
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

This merge and review was created for the purpose of syncing translations. It should not be published as-is even if it looks good because it hasn't been tested yet. Please see additional notes below.

Patch Set 1 #

Patch Set 2 : Added Samsung Internet to browsers list for translations #

Total comments: 7

Patch Set 3 : Fixed misc issues discussed in IRC #

Total comments: 3

Patch Set 4 : Fixed more misc issues discussed in IRC #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats (+2288 lines, -1149 lines) Patch
A globals/browsers.py View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A includes/abb-cross-promotion.html View 1 chunk +38 lines, -0 lines 0 comments Download
R includes/abb-notification.tmpl View 1 chunk +0 lines, -7 lines 0 comments Download
A includes/as-mentioned.tmpl View 1 chunk +63 lines, -0 lines 0 comments Download
A includes/features.html View 1 2 3 1 chunk +34 lines, -0 lines 2 comments Download
M includes/footer.tmpl View 1 chunk +26 lines, -12 lines 0 comments Download
A includes/footnote.tmpl View 1 chunk +17 lines, -0 lines 0 comments Download
A includes/hero-download.html View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A includes/hero-download-conditional.tmpl View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M includes/index.tmpl View 1 2 1 chunk +11 lines, -192 lines 0 comments Download
A includes/install-button.tmpl View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A includes/install-button-templates.tmpl View 1 2 3 1 chunk +21 lines, -0 lines 3 comments Download
M includes/navbar.tmpl View 1 chunk +4 lines, -1 line 0 comments Download
M includes/styles.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
R locales/en/abb-notification.json View 1 chunk +0 lines, -12 lines 0 comments Download
A locales/en/footer.json View 1 chunk +41 lines, -0 lines 0 comments Download
A locales/en/install-button.json View 1 2 1 chunk +110 lines, -0 lines 2 comments Download
M locales/en/menu.json View 1 chunk +3 lines, -0 lines 0 comments Download
M pages/android.md View 1 chunk +2 lines, -0 lines 0 comments Download
M pages/chrome.md View 1 chunk +2 lines, -0 lines 0 comments Download
A pages/download.tmpl View 1 2 3 1 chunk +94 lines, -0 lines 2 comments Download
M pages/edge.md View 1 chunk +2 lines, -0 lines 0 comments Download
M pages/firefox.md View 1 chunk +2 lines, -0 lines 0 comments Download
M pages/index.html View 1 chunk +2 lines, -21 lines 0 comments Download
M pages/internet-explorer.md View 1 chunk +2 lines, -0 lines 0 comments Download
M pages/maxthon.md View 1 chunk +2 lines, -0 lines 0 comments Download
M pages/opera.md View 1 chunk +2 lines, -0 lines 0 comments Download
M pages/safari.md View 1 chunk +2 lines, -0 lines 0 comments Download
M pages/yandex-browser.md View 1 chunk +2 lines, -0 lines 0 comments Download
A static/css/fonts.css View 1 chunk +255 lines, -0 lines 0 comments Download
M static/css/index.css View 1 2 1 chunk +253 lines, -560 lines 0 comments Download
R static/css/index-desktop.css View 1 chunk +0 lines, -151 lines 0 comments Download
R static/css/index-mobile.css View 1 chunk +0 lines, -145 lines 0 comments Download
M static/css/main.css View 1 2 6 chunks +185 lines, -47 lines 4 comments Download
A static/fonts/Source-Sans-Pro/300/cyrillic.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/300/cyrillic-ext.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/300/greek.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/300/greek-ext.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/300/latin.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/300/latin-ext.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/300/vietnamese.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/400/cyrillic.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/400/cyrillic-ext.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/400/greek.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/400/greek-ext.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/400/latin.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/400/latin-ext.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/400/vietnamese.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/700/cyrillic.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/700/cyrillic-ext.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/700/greek.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/700/greek-ext.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/700/latin.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/700/latin-ext.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/700/vietnamese.woff2 View Binary file 0 comments Download
A static/fonts/Source-Sans-Pro/LICENSE.txt View 1 chunk +93 lines, -0 lines 0 comments Download
R static/fonts/SourceSansPro-Light.woff View Binary file 0 comments Download
R static/fonts/SourceSansPro-Regular.woff View Binary file 0 comments Download
R static/fonts/SourceSansPro-Semibold.woff View Binary file 0 comments Download
A static/img/abb-icon.png View Binary file 0 comments Download
A static/img/abb-icon-2x.png View Binary file 0 comments Download
M static/img/abb-logo.png View Binary file 0 comments Download
A static/img/apple-app-store-badge.png View Binary file 0 comments Download
A static/img/apple-app-store-badge.svg View 1 chunk +129 lines, -0 lines 0 comments Download
A static/img/device-desktop.png View Binary file 0 comments Download
A static/img/device-desktop-2x.png View Binary file 0 comments Download
A static/img/device-mobile.png View Binary file 0 comments Download
A static/img/device-mobile.svg View 1 chunk +3 lines, -0 lines 0 comments Download
A static/img/download-icon.png View Binary file 0 comments Download
A static/img/download-icon.svg View 1 chunk +3 lines, -0 lines 0 comments Download
A static/img/external-icon.png View Binary file 0 comments Download
A static/img/external-icon.svg View 1 chunk +13 lines, -0 lines 0 comments Download
A static/img/feature-aa.png View Binary file 0 comments Download
A static/img/feature-aa.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/img/feature-fast.png View Binary file 0 comments Download
A static/img/feature-fast.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/img/feature-safe.png View Binary file 0 comments Download
A static/img/feature-safe.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/img/google-play-badge.png View Binary file 0 comments Download
A static/img/google-play-badge.svg View 1 chunk +89 lines, -0 lines 0 comments Download
A static/img/hero-video.jpg View Binary file 0 comments Download
A static/img/hero-video-2x.jpg View Binary file 0 comments Download
A static/img/media/business-insider.png View Binary file 0 comments Download
A static/img/media/business-insider-2x.png View Binary file 0 comments Download
A static/img/media/mediapost.png View Binary file 0 comments Download
A static/img/media/mediapost-2x.png View Binary file 0 comments Download
A static/img/media/nyt.png View Binary file 0 comments Download
A static/img/media/nyt-2x.png View Binary file 0 comments Download
A static/img/media/techcrunch.png View Binary file 0 comments Download
A static/img/media/techcrunch-2x.png View Binary file 0 comments Download
A static/img/media/wsj.png View Binary file 0 comments Download
A static/img/media/wsj-2x.png View Binary file 0 comments Download
R static/img/video-thumbnail.jpg View Binary file 0 comments Download
A static/js/index.js View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A static/js/vendor/bowser.js View 1 chunk +601 lines, -0 lines 0 comments Download
M static/poland.html View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
juliandoucette
July 30, 2018, 3:48 a.m. (2018-07-30 03:48:42 UTC) #1
juliandoucette
This merge and review was created for the purpose of syncing translations. It should not ...
July 30, 2018, 5:01 a.m. (2018-07-30 05:01:08 UTC) #2
juliandoucette
Patchset 3 also moves the install button and it's dependencies out of hero-download.html. I did ...
July 30, 2018, 4:17 p.m. (2018-07-30 16:17:44 UTC) #3
juliandoucette
https://codereview.adblockplus.org/29841563/diff/29842954/includes/features.html File includes/features.html (right): https://codereview.adblockplus.org/29841563/diff/29842954/includes/features.html#newcode21 includes/features.html:21: <p>{{ feature-safe-body With Adblock Plus avoiding tracking and malware ...
July 30, 2018, 4:46 p.m. (2018-07-30 16:46:14 UTC) #4
ire
Thanks Julian! Here's my first look through: https://codereview.adblockplus.org/29841563/diff/29841659/globals/browsers.py File globals/browsers.py (right): https://codereview.adblockplus.org/29841563/diff/29841659/globals/browsers.py#newcode58 globals/browsers.py:58: 'id': 'samsung', ...
July 31, 2018, 12:10 a.m. (2018-07-31 00:10:14 UTC) #5
juliandoucette
Thanks Ire! I'll try to update this later today. https://codereview.adblockplus.org/29841563/diff/29841659/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29841563/diff/29841659/static/css/main.css#newcode813 static/css/main.css:813: ...
Aug. 2, 2018, 8:51 p.m. (2018-08-02 20:51:59 UTC) #6
juliandoucette
Aug. 3, 2018, 5:47 a.m. (2018-08-03 05:47:03 UTC) #7

Powered by Google App Engine
This is Rietveld