Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/install-button-templates.tmpl

Issue 29841563: Noissue - Merged index_page into master (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Created July 30, 2018, 3:47 a.m.
Right Patch Set: Fixed more misc issues discussed in IRC Created July 30, 2018, 4:40 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
LEFTRIGHT
(no file at all)
1 {% for browser in browsers %}
2 <script id="download-label-{{ browser.id }}" type="text/template">
3 {% if locale in ["en", "de", "fr"] %}
4 {{ get_string("agree-and-install-for-" + browser.id, "install-button") }}
5 {% else %}
6 {{ get_string("install-for-" + browser.id, "install-button") }}
7 {% endif %}
8 </script>
9 {% endfor %}
ire 2018/07/31 00:10:08 NIT/Suggest: Is there a need to end and start 3 di
10
11 {% for browser in browsers %}
juliandoucette 2018/07/30 16:46:12 FIXME / Detail: I added these (temporarily) becaus
ire 2018/07/31 00:10:07 Acknowledged.
12 <script id="install-label-{{ browser.id }}" type="text/template">
13 {{ get_string("install-for-" + browser.id, "install-button") }}
14 </script>
15 {% endfor %}
16
17 {% for browser in browsers %}
18 <script id="agree-and-install-label-{{ browser.id }}" type="text/template">
19 {{ get_string("agree-and-install-for-" + browser.id, "install-button") }}
20 </script>
21 {% endfor %}
LEFTRIGHT

Powered by Google App Engine
This is Rietveld