Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(153)

Issue 29843588: Issue 6823 - Remove unnecessary usage of /u flag (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by Manish Jethani
Modified:
1 year, 1 month ago
Reviewers:
hub, kzar, Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/common.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/snippets.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Manish Jethani
1 year, 1 month ago (2018-07-31 20:31:15 UTC) #1
Manish Jethani
Patch Set 1 Passes tests.
1 year, 1 month ago (2018-07-31 20:32:08 UTC) #2
hub
I was about to submit the same patch. LGTM. We are still missing the case ...
1 year, 1 month ago (2018-07-31 20:53:41 UTC) #3
Manish Jethani
On 2018/07/31 20:53:41, hub wrote: > I was about to submit the same patch. LGTM. ...
1 year, 1 month ago (2018-07-31 20:57:11 UTC) #4
Manish Jethani
1 year, 1 month ago (2018-07-31 20:59:25 UTC) #5
On 2018/07/31 20:57:11, Manish Jethani wrote:
> On 2018/07/31 20:53:41, hub wrote:
> > I was about to submit the same patch. LGTM.
> 
> Thanks
> 
> > We are still missing the case for elemHideEmulation were we have to sanitize
> the
> > `u` flag.
> 
> I think we can leave it there, I don't think anyone is using it for now and
> [...]

OK, I think you should file a separate issue for this. It's not that urgent but
might be a good idea to address this anyway.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5