Issue 29843588: Issue 6823 - Remove unnecessary usage of /u flag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29843588: Issue 6823 - Remove unnecessary usage of /u flag (Closed)

Created:
July 31, 2018, 8:31 p.m. by Manish Jethani

Modified:
July 31, 2018, 9:02 p.m.

Reviewers:
Sebastian Noack, kzar, hub

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Patch Set 1 #

Created: July 31, 2018, 8:31 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	lib/common.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	lib/snippets.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

hub

I was about to submit the same patch. LGTM. We are still missing the case ...

July 31, 2018, 8:53 p.m. (2018-07-31 20:53:41 UTC) #3

Manish Jethani

On 2018/07/31 20:53:41, hub wrote: > I was about to submit the same patch. LGTM. ...

July 31, 2018, 8:57 p.m. (2018-07-31 20:57:11 UTC) #4

Manish Jethani

July 31, 2018, 8:59 p.m. (2018-07-31 20:59:25 UTC) #5

On 2018/07/31 20:57:11, Manish Jethani wrote:
> On 2018/07/31 20:53:41, hub wrote:
> > I was about to submit the same patch. LGTM.
> 
> Thanks
> 
> > We are still missing the case for elemHideEmulation were we have to sanitize
> the
> > `u` flag.
> 
> I think we can leave it there, I don't think anyone is using it for now and
> [...]

OK, I think you should file a separate issue for this. It's not that urgent but
might be a good idea to address this anyway.

Expand All Messages | Collapse All Messages