Noissue - Fix hgreview for Mercurial 4.7: cmdutil.command -> registrar.command

hgreview.py

 import BaseHTTPServer
 import os
 import re
 import socket
 import sys
 import urllib
 
 from mercurial import cmdutil, error
 
 SERVER = 'https://codereview.adblockplus.org'
 UPLOADTOOL_URL = SERVER + '/static/upload.py'
 
 cmdtable = {}
-command = cmdutil.command(cmdtable)
-
+try:
+    command = cmdutil.command(cmdtable)
+except:

[Sebastian Noack, 2018/08/02 17:13:21]

Nit: Bare except is discouraged by PEP-8 (and would also give an error if linted
with flake8/pycodingstyles).

[hub, 2018/08/02 18:16:56]

fixed.

[Sebastian Noack, 2018/08/02 19:11:30]

I suppose catching AttributeError specifically would be sufficient?

[hub, 2018/08/02 19:41:16]

I was being broad, but yes that work.

+    from mercurial import registrar
+    command = registrar.command(cmdtable)
 
 @command('review',
          [
              ('i', 'issue', '', 'If given, adds a patch set to this review, otherwise create a new one.', 'ISSUE'),
              ('r', 'revision', '', 'Revision to diff against or a revision range to upload.', 'REV'),
              ('c', 'change', '', 'A single revision to upload.', 'REV'),
              ('t', 'title', '', 'New review subject or new patch set title.', 'TITLE'),
              ('m', 'message', '', 'New review description or new patch set message.', 'MESSAGE'),
              ('w', 'reviewers', '', 'Add reviewers (comma separated email addresses or @adblockplus.org user names).', 'REVIEWERS'),
              ('', 'cc', '', 'Add CC (comma separated email addresses or @adblockplus.org user names).', 'CC'),
@@ skipping 134 matching lines @@
   </body>
 </html>
 ''' % port
 
     # Run the upload tool
     issue, patchset = scope['RealMain']([upload_path] + args)
 
     # Wait for the page to check in and retrieve issue URL
     if server:
         server.handle_request()