Noissue - Fix hgreview for Mercurial 4.7: cmdutil.command -> registrar.command

Noissue - Fix hgreview for Mercurial 4.7: cmdutil.command -> registrar.command

[hub, 2018-08-02 17:03:48]

Updated Homebrew (macOS) which in turn updated to Mercurial 4.7 (release August
1st). This release broke the API. While there is mention in the release notes
of:

"cmdutil: drop deprecated precursor of registrar.command (API)"

The extension documentation hasn't been updated.

The following patch should be backward compatible.

[hub, 2018-08-02 17:11:15]

and FWIW, I used hgreview to post this review. :-)

[Sebastian Noack, 2018-08-02 17:13:21]

https://codereview.adblockplus.org/29845569/diff/29845570/hgreview.py
File hgreview.py (right):

https://codereview.adblockplus.org/29845569/diff/29845570/hgreview.py#newcode16
hgreview.py:16: except:
Nit: Bare except is discouraged by PEP-8 (and would also give an error if linted
with flake8/pycodingstyles).

[hub, 2018-08-02 18:16:56]

updated patch

https://codereview.adblockplus.org/29845569/diff/29845570/hgreview.py
File hgreview.py (right):

https://codereview.adblockplus.org/29845569/diff/29845570/hgreview.py#newcode16
hgreview.py:16: except:
On 2018/08/02 17:13:21, Sebastian Noack wrote:
> Nit: Bare except is discouraged by PEP-8 (and would also give an error if
linted
> with flake8/pycodingstyles).

fixed.

[Sebastian Noack, 2018-08-02 19:11:30]

https://codereview.adblockplus.org/29845569/diff/29845570/hgreview.py
File hgreview.py (right):

https://codereview.adblockplus.org/29845569/diff/29845570/hgreview.py#newcode16
hgreview.py:16: except:
On 2018/08/02 18:16:56, hub wrote:
> On 2018/08/02 17:13:21, Sebastian Noack wrote:
> > Nit: Bare except is discouraged by PEP-8 (and would also give an error if
> linted
> > with flake8/pycodingstyles).
> 
> fixed.

I suppose catching AttributeError specifically would be sufficient?

[hub, 2018-08-02 19:41:16]

Updated patch

https://codereview.adblockplus.org/29845569/diff/29845570/hgreview.py
File hgreview.py (right):

https://codereview.adblockplus.org/29845569/diff/29845570/hgreview.py#newcode16
hgreview.py:16: except:
On 2018/08/02 19:11:30, Sebastian Noack wrote:
> On 2018/08/02 18:16:56, hub wrote:
> > On 2018/08/02 17:13:21, Sebastian Noack wrote:
> > > Nit: Bare except is discouraged by PEP-8 (and would also give an error if
> > linted
> > > with flake8/pycodingstyles).
> > 
> > fixed.
> 
> I suppose catching AttributeError specifically would be sufficient?

I was being broad, but yes that work.

[Sebastian Noack, 2018-08-02 20:46:27]

LGTM

[tlucas, 2018-08-02 20:46:58]

On 2018/08/02 20:46:27, Sebastian Noack wrote:
> LGTM

LGTM