hgreview.py - Issue 29845569: Noissue - Fix hgreview for Mercurial 4.7: cmdutil.command -> registrar.command

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: hgreview.py

Issue 29845569: Noissue - Fix hgreview for Mercurial 4.7: cmdutil.command -> registrar.command (Closed) Base URL: https://hg.adblockplus.org/codingtools/

Patch Set: Don't use bare exceptions Created Aug. 2, 2018, 6:16 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: hgreview.py

===================================================================

--- a/hgreview.py

+++ b/hgreview.py

@@ -6,18 +6,21 @@

import urllib

from mercurial import cmdutil, error

SERVER = 'https://codereview.adblockplus.org'

UPLOADTOOL_URL = SERVER + '/static/upload.py'

cmdtable = {}

-command = cmdutil.command(cmdtable)

+try:

+ command = cmdutil.command(cmdtable)

+except Exception:

+ from mercurial import registrar

+ command = registrar.command(cmdtable)

@command('review',

[

('i', 'issue', '', 'If given, adds a patch set to this review, otherwise create a new one.', 'ISSUE'),

('r', 'revision', '', 'Revision to diff against or a revision range to upload.', 'REV'),

('c', 'change', '', 'A single revision to upload.', 'REV'),

('t', 'title', '', 'New review subject or new patch set title.', 'TITLE'),

('m', 'message', '', 'New review description or new patch set message.', 'MESSAGE'),

« no previous file with comments | « no previous file | no next file » | no next file with comments »