Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(196)

Issue 29847558: Issue 6504 - Ignore useInlineStyles for now

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 2 days ago by Manish Jethani
Modified:
3 days, 15 hours ago
Reviewers:
hub
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

See rationale in https://issues.adblockplus.org/ticket/6504#comment:9

Patch Set 1 #

Patch Set 2 : Update issue number in comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M lib/content/elemHideEmulation.js View 1 2 chunks +10 lines, -11 lines 1 comment Download

Messages

Total messages: 6
Manish Jethani
1 week, 2 days ago (2018-08-04 12:48:18 UTC) #1
Manish Jethani
Patch Set 1
1 week, 2 days ago (2018-08-04 12:49:41 UTC) #2
hub
commit message says this is 6422, but I saw this review associated to issue 6504.
3 days, 21 hours ago (2018-08-10 13:54:22 UTC) #3
Manish Jethani
On 2018/08/10 13:54:22, hub wrote: > commit message says this is 6422, but I saw ...
3 days, 20 hours ago (2018-08-10 14:24:21 UTC) #4
Manish Jethani
Patch Set 2: Update issue number in comment
3 days, 20 hours ago (2018-08-10 14:27:31 UTC) #5
hub
3 days, 15 hours ago (2018-08-10 19:43:16 UTC) #6
https://codereview.adblockplus.org/29847558/diff/29852562/lib/content/elemHid...
File lib/content/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29847558/diff/29852562/lib/content/elemHid...
lib/content/elemHideEmulation.js:614: this.useInlineStyles = true;
so if we don't use it, and since the code below gets removed, then why doesn't
this property get removed?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5