Issue 6504 - Remove useInlineStyles for now

See rationale in https://issues.adblockplus.org/ticket/6504#comment:9

[Manish Jethani, 2018-08-04 12:49:41]

Patch Set 1

[hub, 2018-08-10 13:54:22]

commit message says this is 6422, but I saw this review associated to issue
6504.

[Manish Jethani, 2018-08-10 14:24:21]

On 2018/08/10 13:54:22, hub wrote:
> commit message says this is 6422, but I saw this review associated to issue
> 6504.

Sorry, I've updated it now.

[Manish Jethani, 2018-08-10 14:27:31]

Patch Set 2: Update issue number in comment

[hub, 2018-08-10 19:43:16]

https://codereview.adblockplus.org/29847558/diff/29852562/lib/content/elemHid...
File lib/content/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29847558/diff/29852562/lib/content/elemHid...
lib/content/elemHideEmulation.js:614: this.useInlineStyles = true;
so if we don't use it, and since the code below gets removed, then why doesn't
this property get removed?

[Manish Jethani, 2018-08-14 16:50:16]

https://codereview.adblockplus.org/29847558/diff/29852562/lib/content/elemHid...
File lib/content/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29847558/diff/29852562/lib/content/elemHid...
lib/content/elemHideEmulation.js:614: this.useInlineStyles = true;
On 2018/08/10 19:43:16, hub wrote:
> so if we don't use it, and since the code below gets removed, then why doesn't
> this property get removed?

I left it there with a comment sorta hoping that someday we might get around to
using it. We could just as well remove it entirely.

What do you think?

[hub, 2018-08-14 17:24:41]

https://codereview.adblockplus.org/29847558/diff/29852562/lib/content/elemHid...
File lib/content/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29847558/diff/29852562/lib/content/elemHid...
lib/content/elemHideEmulation.js:614: this.useInlineStyles = true;
On 2018/08/14 16:50:16, Manish Jethani wrote:
> On 2018/08/10 19:43:16, hub wrote:
> > so if we don't use it, and since the code below gets removed, then why
doesn't
> > this property get removed?
> 
> I left it there with a comment sorta hoping that someday we might get around
to
> using it. We could just as well remove it entirely.
> 
> What do you think?

Since you remove the code below, I believe it is pointless to leave this here.

[Manish Jethani, 2018-08-14 17:46:22]

Patch Set 3: Remove useInlineStyles flag

https://codereview.adblockplus.org/29847558/diff/29852562/lib/content/elemHid...
File lib/content/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29847558/diff/29852562/lib/content/elemHid...
lib/content/elemHideEmulation.js:614: this.useInlineStyles = true;
On 2018/08/14 17:24:41, hub wrote:
> On 2018/08/14 16:50:16, Manish Jethani wrote:
> > On 2018/08/10 19:43:16, hub wrote:
> > > so if we don't use it, and since the code below gets removed, then why
> doesn't
> > > this property get removed?
> > 
> > I left it there with a comment sorta hoping that someday we might get around
> to
> > using it. We could just as well remove it entirely.
> > 
> > What do you think?
> 
> Since you remove the code below, I believe it is pointless to leave this here.

Sounds OK to me.

Done.

[hub, 2018-08-14 19:11:54]

LGTM

[Manish Jethani, 2018-08-15 07:48:52]

Patch Set 4: Remove one more reference to useInlineStyles

Tests were failing because of this; this is not needed any more.

[hub, 2018-08-15 12:11:53]

LGTM