Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29850577: Issue 6391 - Temporarily disable Firefox testing by default (Closed)

Created:
Aug. 8, 2018, 4:08 p.m. by hub
Modified:
Aug. 8, 2018, 6:57 p.m.
Reviewers:
Manish Jethani, kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6391 - Temporarily disable Firefox testing by default

Patch Set 1 #

Patch Set 2 : Update README #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M README.md View 1 1 chunk +1 line, -1 line 0 comments Download
M test_runner.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
hub
Aug. 8, 2018, 4:08 p.m. (2018-08-08 16:08:13 UTC) #1
hub
Apparently the 4 year old OS on TravisCI doesn't like it.
Aug. 8, 2018, 4:09 p.m. (2018-08-08 16:09:03 UTC) #2
Manish Jethani
We should update the README file as well.
Aug. 8, 2018, 4:13 p.m. (2018-08-08 16:13:58 UTC) #3
sergei
not a blocker, just a suggestion: can it be disabled only for travis-ci, I mean ...
Aug. 8, 2018, 4:16 p.m. (2018-08-08 16:16:06 UTC) #4
Manish Jethani
On 2018/08/08 16:16:06, sergei wrote: > not a blocker, just a suggestion: > can it ...
Aug. 8, 2018, 4:17 p.m. (2018-08-08 16:17:29 UTC) #5
hub
patch has been updated.
Aug. 8, 2018, 4:26 p.m. (2018-08-08 16:26:25 UTC) #6
Manish Jethani
Aug. 8, 2018, 4:27 p.m. (2018-08-08 16:27:36 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld