Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(296)

Issue 29851654: Issue 6850 - Remove generation of checksums (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by rhowell
Modified:
2 months ago
Base URL:
https://hg.adblockplus.org/python-abp/
Visibility:
Public.

Description

Issue 6850 - Remove generation of checksums

Patch Set 1 #

Patch Set 2 : Remove checksum documentation from the README #

Total comments: 1

Patch Set 3 : Add test for checksum removal, fix README references #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -31 lines) Patch
M README.md View 1 2 3 chunks +7 lines, -9 lines 0 comments Download
M abp/filters/renderer.py View 3 chunks +1 line, -20 lines 0 comments Download
M tests/test_render_script.py View 1 chunk +0 lines, -1 line 0 comments Download
M tests/test_renderer.py View 1 2 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9
rhowell
2 months, 1 week ago (2018-08-09 21:46:39 UTC) #1
rhowell
In renderer.py, in _remove_duplicates(), I left the logic in that removes checksums from fragments, because ...
2 months, 1 week ago (2018-08-09 21:50:58 UTC) #2
rhowell
Ok, fixed the README. :)
2 months, 1 week ago (2018-08-09 22:09:16 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29851654/diff/29851660/README.md File README.md (left): https://codereview.adblockplus.org/29851654/diff/29851660/README.md#oldcode32 README.md:32: a [checksum][1]. Now we have an unreferenced URL at ...
2 months, 1 week ago (2018-08-09 22:37:03 UTC) #4
Sebastian Noack
On 2018/08/09 21:50:58, rhowell wrote: > In renderer.py, in _remove_duplicates(), I left the logic in ...
2 months, 1 week ago (2018-08-09 22:48:51 UTC) #5
rhowell
On 2018/08/09 22:37:03, Sebastian Noack wrote: > https://codereview.adblockplus.org/29851654/diff/29851660/README.md > File README.md (left): > > https://codereview.adblockplus.org/29851654/diff/29851660/README.md#oldcode32 ...
2 months, 1 week ago (2018-08-10 21:50:04 UTC) #6
Sebastian Noack
On 2018/08/10 21:50:04, rhowell wrote: > I don't really see anywhere where the reference to ...
2 months, 1 week ago (2018-08-10 22:07:22 UTC) #7
Sebastian Noack
LGTM
2 months ago (2018-08-14 19:20:19 UTC) #8
Vasily Kuznetsov
2 months ago (2018-08-16 11:21:47 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5