Issue 6850 - Remove generation of checksums

Issue 6850 - Remove generation of checksums

[rhowell, 2018-08-09 21:50:58]

In renderer.py, in _remove_duplicates(), I left the logic in that removes
checksums from fragments, because this still seems like useful functionality.
But, they've been removed from everywhere else I can find. Oops, except the
README. New patch coming momentarily...

[rhowell, 2018-08-09 22:09:16]

Ok, fixed the README. :)

[Sebastian Noack, 2018-08-09 22:37:03]

https://codereview.adblockplus.org/29851654/diff/29851660/README.md
File README.md (left):

https://codereview.adblockplus.org/29851654/diff/29851660/README.md#oldcode32
README.md:32: a [checksum][1].
Now we have an unreferenced URL at the bottom.

[Sebastian Noack, 2018-08-09 22:48:51]

On 2018/08/09 21:50:58, rhowell wrote:
> In renderer.py, in _remove_duplicates(), I left the logic in that removes
> checksums from fragments, because this still seems like useful functionality.

Indeed, if the fragment has a checksum, and it's just copied over to the output,
the checksum would no longer be valid in the context of the resulting list,
which at very least would cause the list to be rejected in the legacy Firefox
extension. However, is this covered by any tests? I suppose the previous tests
merely asserted that the final checksum is in there. So now we might want to
test that any given Checksum is stripped instead.

[rhowell, 2018-08-10 21:50:04]

On 2018/08/09 22:37:03, Sebastian Noack wrote:
> https://codereview.adblockplus.org/29851654/diff/29851660/README.md
> File README.md (left):
> 
> https://codereview.adblockplus.org/29851654/diff/29851660/README.md#oldcode32
> README.md:32: a [checksum][1].
> Now we have an unreferenced URL at the bottom.

Apparently there are two unreferenced URLs at the bottom (though the references
don't show up, at least when Github displays the README here:
https://github.com/adblockplus/python-abp).

But it seems the reference to the options page was never used. Is was added in
this commit, unused at the time:
https://github.com/adblockplus/python-abp/commit/7edccddcf15f4b812dc1807bc6ec...

I don't really see anywhere where the reference to the options page would be
super useful. But, I could still reference the special-comments, maybe around [a
version and a timestamp][1].

[Sebastian Noack, 2018-08-10 22:07:22]

On 2018/08/10 21:50:04, rhowell wrote:
> I don't really see anywhere where the reference to the options page would be
> super useful. But, I could still reference the special-comments, maybe around
[a
> version and a timestamp][1].

Sounds good.

[Sebastian Noack, 2018-08-14 19:20:19]

LGTM

[Vasily Kuznetsov, 2018-08-16 11:21:47]

LGTM