Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29853558: Noissue - Delete element hiding domain entry once all filters removed (Closed)

Created:
Aug. 11, 2018, 1:04 p.m. by Manish Jethani
Modified:
Aug. 16, 2018, 4:55 a.m.
Reviewers:
kzar, Jon Sonesen, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

This is useful when unsubscribing from a filter list with enough unique domains that don't exist in any other filter list (e.g. region-specific lists like EasyList China).

Patch Set 1 #

Patch Set 2 : Rebase, add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M lib/elemHide.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M test/elemHide.js View 1 2 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
Aug. 11, 2018, 1:04 p.m. (2018-08-11 13:04:37 UTC) #1
Manish Jethani
Patch Set 1
Aug. 11, 2018, 1:07 p.m. (2018-08-11 13:07:28 UTC) #2
hub
I wish there was some test for this as well.
Aug. 15, 2018, 9:41 p.m. (2018-08-15 21:41:37 UTC) #3
Manish Jethani
Patch Set 2: Add tests
Aug. 15, 2018, 10:13 p.m. (2018-08-15 22:13:55 UTC) #4
hub
Aug. 16, 2018, 1:23 a.m. (2018-08-16 01:23:24 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld