lib/elemHide.js - Issue 29853558: Noissue - Delete element hiding domain entry once all filters removed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/elemHide.js

Issue 29853558: Noissue - Delete element hiding domain entry once all filters removed (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Rebase, add tests Created Aug. 15, 2018, 10:13 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/elemHide.js

===================================================================

--- a/lib/elemHide.js

+++ b/lib/elemHide.js

@@ -168,17 +168,22 @@

// Conditionally applied element hiding filters

else

{

let domains = filter.domains || defaultDomains;

for (let domain of domains.keys())

{

let filters = filtersByDomain.get(domain);

if (filters)

+ {

filters.delete(filter);

+ if (filters.size == 0)

+ filtersByDomain.delete(domain);

+ }

}

knownFilters.delete(filter);

FilterNotifier.emit("elemhideupdate");

/**

« no previous file with comments | « no previous file | test/elemHide.js » ('j') | no next file with comments »