Noissue - Use regular expression to parse filter options

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 744 matching lines @@
   }
 
   let contentType = null;
   let matchCase = null;
   let domains = null;
   let sitekeys = null;
   let thirdParty = null;
   let collapse = null;
   let csp = null;
   let rewrite = null;
-  let options;
+
   let match = text.includes("$") ? Filter.optionsRegExp.exec(text) : null;
   if (match)
   {
-    options = match[1].split(",");
     text = match.input.substr(0, match.index);
-    for (let option of options)
+
+    for (let re = /([^,=]+)(?:=([^,]*))?/g, m; m = re.exec(match[1]);)
     {
-      let value = null;
-      let separatorIndex = option.indexOf("=");
-      if (separatorIndex >= 0)
-      {
-        value = option.substr(separatorIndex + 1);
-        option = option.substr(0, separatorIndex);
-      }
+      let [, option, value] = m;
 
       let inverse = option[0] == "~";
       if (inverse)
         option = option.substr(1);
 
       let type = RegExpFilter.typeMap[option.replace(/-/, "_").toUpperCase()];
       if (type)
       {
         if (inverse)
         {
@@ skipping 397 matching lines @@
 
   /**
    * Script that should be executed
    * @type {string}
    */
   get script()
   {
     return this.body;
   }
 });