Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29854584: Noissue - Use regular expression to parse filter options (Closed)

Created:
Aug. 13, 2018, 2:42 a.m. by Manish Jethani
Modified:
Sept. 5, 2018, 6:21 a.m.
Reviewers:
hub
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M lib/filterClasses.js View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
Aug. 13, 2018, 2:42 a.m. (2018-08-13 02:42:17 UTC) #1
Manish Jethani
Patch Set 1 This is less code and just as fast.
Aug. 13, 2018, 2:43 a.m. (2018-08-13 02:43:08 UTC) #2
hub
are we sure of the performance?
Sept. 4, 2018, 5:52 p.m. (2018-09-04 17:52:36 UTC) #3
Manish Jethani
Sept. 5, 2018, 6:21 a.m. (2018-09-05 06:21:39 UTC) #4
On 2018/09/04 17:52:36, hub wrote:
> are we sure of the performance?

The performance seems slightly worse.

I'm closing this.

Powered by Google App Engine
This is Rietveld